Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up CRD conversion code structure #113151

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Clean up CRD conversion code structure #113151

merged 4 commits into from
Dec 13, 2022

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Oct 18, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Refactor the CRD conversion code:

  • Rename crConverter to delegatingCRConverter
  • Make creating a delegatingCRConverter a package function NewDelegatingConverter
  • Move list/single item handling from the webhook converter into delegatingCRConverter
  • Rename crConverterInterface to CRConverter so it is exported
  • Change the CRConverter interface's input/output to be *unstructured.UnstructuredList
  • Create and export NewNOPConverter

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 18, 2022
@ncdc
Copy link
Member Author

ncdc commented Oct 18, 2022

/cc @jpbetz @hasheddan

@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 18, 2022
@ncdc
Copy link
Member Author

ncdc commented Oct 18, 2022

/sig api-machinery

@dims
Copy link
Member

dims commented Oct 19, 2022

/retest

@ncdc
Copy link
Member Author

ncdc commented Oct 19, 2022

@dims thx for the retest but I have some things I probably need to fix to get CI passing 😄

@ncdc
Copy link
Member Author

ncdc commented Oct 19, 2022

Not sure if this e2e failure is from my changes ... let's try:

/retest

@leilajal
Copy link
Contributor

/cc @logicalhan
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 20, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2022
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2022
@leilajal
Copy link
Contributor

/triage accepted

@fedebongio
Copy link
Contributor

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot removed the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Nov 1, 2022
@ncdc
Copy link
Member Author

ncdc commented Dec 13, 2022

Flake in pkg/controller/volume/attachdetach/reconciler Test_Run_OneVolumeDetachFailNodeWithReadWriteOnce

/retest

@k8s-ci-robot k8s-ci-robot merged commit f524d76 into kubernetes:master Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Dec 13, 2022
@ncdc ncdc deleted the refactor-crd-conversion branch March 14, 2023 14:51
@liggitt liggitt mentioned this pull request Apr 12, 2023
Closed
ncdc added a commit to ncdc/kubernetes that referenced this pull request Apr 13, 2023
@ncdc
Revert "Merge pull request kubernetes#113151 from ncdc/refactor-crd-c…
432a301 
…onversion"

This reverts commit f524d76, reversing
changes made to c2b5457.
@ncdc ncdc mentioned this pull request Apr 13, 2023
Merged
ncdc added a commit to ncdc/kubernetes that referenced this pull request Apr 13, 2023
@ncdc
Revert "Merge pull request kubernetes#113151 from ncdc/refactor-crd-c…
a1f97a3 
…onversion"

This reverts commit f524d76, reversing
changes made to c2b5457.
@bertinatto bertinatto mentioned this pull request Jun 20, 2023
Closed
sttts added a commit to sttts/kubernetes that referenced this pull request Sep 11, 2023
@sttts
Revert "Revert "Merge pull request kubernetes#113151 from ncdc/refact…
f974c1d 
…or-crd-conversion""

This reverts commit 432a301.
sttts added a commit to sttts/kubernetes that referenced this pull request Sep 11, 2023
@sttts
Revert "Revert "Merge pull request kubernetes#113151 from ncdc/refact…
89e7fa4 
…or-crd-conversion""

This reverts commit 432a301.
sttts added a commit to sttts/kubernetes that referenced this pull request Sep 13, 2023
@sttts
SQUASH: Revert "Revert "Merge pull request kubernetes#113151 from ncd…
12e3469 
…c/refactor-crd-conversion""

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
sttts added a commit to sttts/kubernetes that referenced this pull request Sep 13, 2023
@sttts
SQUASH: Revert "Revert "Merge pull request kubernetes#113151 from ncd…
793880a 
…c/refactor-crd-conversion""

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
sttts added a commit to kcp-dev/kubernetes that referenced this pull request Sep 13, 2023
@sttts
Revert "Revert "Merge pull request kubernetes#113151 from ncdc/refact…
2fcf1bd 
…or-crd-conversion""

This reverts commit 432a301.
sttts added a commit to sttts/kubernetes that referenced this pull request Sep 28, 2023
@sttts
Revert: Revert: Clean up CRD conversion code structure
01d2b61 
This is a new attempt on kubernetes#113151 and kubernetes#114959, which got reverted in kubernetes#117301 because they seem to be causing kubernetes#117260.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
@sttts sttts mentioned this pull request Sep 28, 2023
Closed
sttts added a commit to sttts/kubernetes that referenced this pull request Jan 18, 2024
@sttts
Revert: Revert: Clean up CRD conversion code structure
9d206b9 
This is a new attempt on kubernetes#113151 and kubernetes#114959, which got reverted in kubernetes#117301 because they seem to be causing kubernetes#117260.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
sttts added a commit to sttts/kubernetes that referenced this pull request Jan 18, 2024
@sttts
Revert: Revert: Clean up CRD conversion code structure
e937cba 
This is a new attempt on kubernetes#113151 and kubernetes#114959, which got reverted in kubernetes#117301 because they seem to be causing kubernetes#117260.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
xrstf pushed a commit to xrstf/kubernetes that referenced this pull request Jan 22, 2024
@sttts @xrstf
Revert: Revert: Clean up CRD conversion code structure
8ee2e62 
This is a new attempt on kubernetes#113151 and kubernetes#114959, which got reverted in kubernetes#117301 because they seem to be causing kubernetes#117260.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
xrstf pushed a commit to xrstf/kubernetes that referenced this pull request Jan 22, 2024
@sttts @xrstf
Revert: Revert: Clean up CRD conversion code structure
b0e48f8 
This is a new attempt on kubernetes#113151 and kubernetes#114959, which got reverted in kubernetes#117301 because they seem to be causing kubernetes#117260.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
xrstf pushed a commit to xrstf/kubernetes that referenced this pull request Jan 22, 2024
@sttts @xrstf
Revert: Revert: Clean up CRD conversion code structure
f270398 
This is a new attempt on kubernetes#113151 and kubernetes#114959, which got reverted in kubernetes#117301 because they seem to be causing kubernetes#117260.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
xrstf pushed a commit to xrstf/kubernetes that referenced this pull request Jan 22, 2024
@sttts @xrstf
Revert: Revert: Clean up CRD conversion code structure
74d8c64 
This is a new attempt on kubernetes#113151 and kubernetes#114959, which got reverted in kubernetes#117301 because they seem to be causing kubernetes#117260.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
xrstf pushed a commit to xrstf/kubernetes that referenced this pull request Jan 22, 2024
@sttts @xrstf
Revert: Revert: Clean up CRD conversion code structure
fb93c9f 
This is a new attempt on kubernetes#113151 and kubernetes#114959, which got reverted in kubernetes#117301 because they seem to be causing kubernetes#117260.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
xrstf pushed a commit to xrstf/kubernetes that referenced this pull request Jan 22, 2024
@sttts @xrstf
Revert: Revert: Clean up CRD conversion code structure
0d8416e 
This is a new attempt on kubernetes#113151 and kubernetes#114959, which got reverted in kubernetes#117301 because they seem to be causing kubernetes#117260.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
xrstf pushed a commit to xrstf/kubernetes that referenced this pull request Jan 23, 2024
@sttts @xrstf
Revert: Revert: Clean up CRD conversion code structure
e52b7d0 
This is a new attempt on kubernetes#113151 and kubernetes#114959, which got reverted in kubernetes#117301 because they seem to be causing kubernetes#117260.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
xrstf pushed a commit to xrstf/kubernetes that referenced this pull request Jan 23, 2024
@sttts @xrstf
Revert: Revert: Clean up CRD conversion code structure
dcabc8c 
This is a new attempt on kubernetes#113151 and kubernetes#114959, which got reverted in kubernetes#117301 because they seem to be causing kubernetes#117260.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
xrstf pushed a commit to xrstf/kubernetes that referenced this pull request Jan 23, 2024
@sttts @xrstf
Revert: Revert: Clean up CRD conversion code structure
3552c00 
This is a new attempt on kubernetes#113151 and kubernetes#114959, which got reverted in kubernetes#117301 because they seem to be causing kubernetes#117260.

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
rayowang pushed a commit to rayowang/kubernetes that referenced this pull request Feb 9, 2024
@ncdc
Revert "Merge pull request kubernetes#113151 from ncdc/refactor-crd-c…
43336d0 
…onversion"

This reverts commit f524d76, reversing
changes made to c2b5457.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@liggitt liggitt liggitt left review comments

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

@hasheddan hasheddan Awaiting requested review from hasheddan

@logicalhan logicalhan Awaiting requested review from logicalhan

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@jpbetz jpbetz

@liggitt liggitt

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ncdc @dims @leilajal @fedebongio @stevekuznetsov @jpbetz @liggitt @k8s-ci-robot @deads2k