Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop monit kube-addon on nodes. #11320

Merged
merged 1 commit into from
Jul 16, 2015
Merged

Conversation

dchen1107
Copy link
Member

#11215

I think this is not critical for v1.0, but could be convinced otherwise. :-)

cc/ @wojtek-t @yujuhong @zmerlynn @brendandburns

@k8s-bot
Copy link

k8s-bot commented Jul 15, 2015

GCE e2e build/test passed for commit 7e66523.

@wojtek-t
Copy link
Member

LGTM

@yujuhong
Copy link
Contributor

LGTM. Agreed that this is not critical, although monit tends to spam its log without this fix :)

@gmarek
Copy link
Contributor

gmarek commented Jul 15, 2015

+1.

@dchen1107 dchen1107 added this to the v1.0-post milestone Jul 15, 2015
@dchen1107 dchen1107 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2015
@thockin
Copy link
Member

thockin commented Jul 16, 2015

LGTM, after conversation worthwhile for 1.0

ArtfulCoder added a commit that referenced this pull request Jul 16, 2015
Stop monit kube-addon on nodes.
@ArtfulCoder ArtfulCoder merged commit aeb6599 into kubernetes:master Jul 16, 2015
@dchen1107 dchen1107 modified the milestones: v1.0, v1.0-post Jul 16, 2015
zmerlynn added a commit that referenced this pull request Jul 17, 2015
…320-upstream-release-1.0

Automated cherry pick of #11320
@zmerlynn zmerlynn mentioned this pull request Jul 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants