Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove dependency on github.com/pkg/errors #113672

Merged
merged 1 commit into from
Dec 9, 2022
Merged

fix: Remove dependency on github.com/pkg/errors #113672

merged 1 commit into from
Dec 9, 2022

Conversation

falser101
Copy link
Contributor

Signed-off-by: jianfei.zhang jianfei.zhang@daocloud.io

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #113627

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @falser101. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 7, 2022
@falser101
Copy link
Contributor Author

@pacoxu

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 7, 2022
@pacoxu
Copy link
Member

pacoxu commented Nov 7, 2022

/ok-to-test
/lgtm
/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 7, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2022
@falser101
Copy link
Contributor Author

/retest-required

@bart0sh
Copy link
Contributor

bart0sh commented Nov 8, 2022

/lgtm

@falser101
Copy link
Contributor Author

@pacoxu help approve

@dims
Copy link
Member

dims commented Nov 8, 2022

/assign @klueska @mrunalp

@klueska
Copy link
Contributor

klueska commented Nov 8, 2022 •
edited

I will approve this now (because it's late for me and I won't be around to approve it later), but please address my comment above before unholding it

/approve
/hold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: falser101, klueska

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 8, 2022
@falser101
fix: Remove dependency on github.com/pkg/errors
01a6668 
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2022
@falser101
Copy link
Contributor Author

I will approve this now (because it's late for me and I won't be around to approve it later), but please address my comment above before unholding it

/approve /hold

down!

pacoxu
pacoxu reviewed Nov 9, 2022
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 9, 2022
@bart0sh
Copy link
Contributor

bart0sh commented Nov 9, 2022

/test pull-kubernetes-e2e-capz-windows-containerd

1 similar comment
@falser101
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-containerd

@falser101
Copy link
Contributor Author

falser101 commented Nov 10, 2022 •
edited

This was approved before code freeze. Can anyone help to add the milestone label?
@pacoxu
@SergeyKanzhelev
@bart0sh

@dims
Copy link
Member

dims commented Nov 14, 2022

this is not a bug or a test problem, let's land it when 1.27 opens up

/milestone v1.27

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Nov 14, 2022
@bart0sh bart0sh moved this from Triage to Done in SIG Node PR Triage Dec 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6c0f680 into kubernetes:master Dec 9, 2022
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.27, v1.26 Dec 9, 2022
@liggitt liggitt modified the milestones: v1.26, v1.27 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klueska klueska klueska left review comments

@pacoxu pacoxu pacoxu left review comments

@krmayankk krmayankk Awaiting requested review from krmayankk

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@mrunalp mrunalp

@klueska klueska

@pacoxu pacoxu

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

Remove dependency on github.com/pkg/errors
8 participants
@falser101 @k8s-ci-robot @pacoxu @bart0sh @dims @klueska @mrunalp @liggitt