Fix etcd path construction #113687
Merged
Fix etcd path construction #113687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/cherry-pick-not-approved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavalamp, tallclair The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
Verolop
added
the
cherry-pick-approved
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
saschagrunert
added a commit
to saschagrunert/release
that referenced
this pull request
Nov 11, 2022
A release notes text can be similar between PRs, for example if they carry no other information than `NONE`. In that case it could be still possible that CVE data fields are present, which are not being serialized at all. This means we would dedup two CVE's into one while both contain different data fields. To avoid that, we now also take the whole markdown into account for de-duplication. The markdown also includes the PR number and the author, for example: ``` NONE ([#113687](kubernetes/kubernetes#113687), [@tallclair](https://github.com/tallclair)) [SIG API Machinery] ``` As a result, we will now have the chance to publish multiple CVE's via different PRs while all of them contain the official release note `NONE`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/release
that referenced
this pull request
Nov 11, 2022
A release notes text can be similar between PRs, for example if they carry no other information than `NONE`. In that case it could be still possible that CVE data fields are present, which are not being serialized at all. This means we would dedup two CVE's into one while both contain different data fields. To avoid that, we now also take the whole markdown into account for de-duplication. The markdown also includes the PR number and the author, for example: ``` NONE ([#113687](kubernetes/kubernetes#113687), … ``` As a result, we will now have the chance to publish multiple CVE's via different PRs while all of them contain the official release note `NONE`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/release
that referenced
this pull request
Nov 11, 2022
A release notes text can be similar between PRs, for example if they carry no other information than `NONE`. In that case it could be still possible that CVE data fields are present, which are not being serialized at all. This means we would dedup two CVE's into one while both contain different data fields. To avoid that, we now also take the whole markdown into account for de-duplication. The markdown also includes the PR number and the author, for example: ``` NONE ([#113687](kubernetes/kubernetes#113687), … ``` As a result, we will now have the chance to publish multiple CVE's via different PRs while all of them contain the official release note `NONE`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/release
that referenced
this pull request
Nov 11, 2022
A release notes text can be similar between PRs, for example if they carry no other information than `NONE`. In that case it could be still possible that CVE data fields are present, which are not being serialized at all. This means we would dedup two CVE's into one while both contain different data fields. To avoid that, we now also take the whole markdown into account for de-duplication. The markdown also includes the PR number and the author, for example: ``` NONE ([#113687](kubernetes/kubernetes#113687), … ``` As a result, we will now have the chance to publish multiple CVE's via different PRs while all of them contain the official release note `NONE`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/release
that referenced
this pull request
Nov 11, 2022
A release notes text can be similar between PRs, for example if they carry no other information than `NONE`. In that case it could be still possible that CVE data fields are present, which are not being serialized at all. This means we would dedup two CVE's into one while both contain different data fields. To avoid that, we now also take the whole markdown into account for de-duplication. The markdown also includes the PR number and the author, for example: ``` NONE ([#113687](kubernetes/kubernetes#113687), … ``` As a result, we will now have the chance to publish multiple CVE's via different PRs while all of them contain the official release note `NONE`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
added a commit
to saschagrunert/release
that referenced
this pull request
Nov 11, 2022
A release notes text can be similar between PRs, for example if they carry no other information than `NONE`. In that case it could be still possible that CVE data fields are present, which are not being serialized at all. This means we would dedup two CVE's into one while both contain different data fields. To avoid that, we now also take the whole markdown into account for de-duplication. The markdown also includes the PR number and the author, for example: ``` NONE ([#113687](kubernetes/kubernetes#113687), … ``` As a result, we will now have the chance to publish multiple CVE's via different PRs while all of them contain the official release note `NONE`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
wespanther
pushed a commit
to wespanther/release
that referenced
this pull request
Jun 2, 2023
A release notes text can be similar between PRs, for example if they carry no other information than `NONE`. In that case it could be still possible that CVE data fields are present, which are not being serialized at all. This means we would dedup two CVE's into one while both contain different data fields. To avoid that, we now also take the whole markdown into account for de-duplication. The markdown also includes the PR number and the author, for example: ``` NONE ([#113687](kubernetes/kubernetes#113687), … ``` As a result, we will now have the chance to publish multiple CVE's via different PRs while all of them contain the official release note `NONE`. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes etcd path construction to handle invalid input.
Does this PR introduce a user-facing change?
/sig api-machinery
/milestone v1.22