-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(framework): fix the bug on PreFilter skip #113779
Conversation
@sanposhiho: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kubernetes/sig-scheduling-leads Sorry for the bug. |
09f2952
to
c654b80
Compare
c654b80
to
2470b9c
Compare
2470b9c
to
874f3d4
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sanposhiho The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sanposhiho: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/close include this fix in a roll forward PR |
@alculquicondor: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for merging revert PR. |
What type of PR is this?
/priority critical-urgent
/kind bug
/sig scheduling
What this PR does / why we need it:
#112637 got merged yesterday and it supports Skip status in the Filter plugin.
But, in the current implementation, when any PreFilter returns skip status, it results in unschedulable Pod.
We don't experience this issue because we don't return Skip in any in-tree plugins. But, it'll be an issue when users see the release note, realize the Skip in PreFIlter, and then try it on their custom plugins.
The skip status should be treated as success in all other places than calculating
SkipFilterPlugins
in the cycle state.And, I added the test code on
schedulePod
func, which I should've implemented in #112637 along with other unit tests, and realized the bug 馃檱 馃檱Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Should I revert #112637 instead of aiming to merge it in v1.26?
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: