New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add etcd 3.5.6-0 to kuebadm supported etcd version #114232
Conversation
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Dec 1 09:40:53 UTC 2022. |
@pacoxu: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, i thought we have logic in kubeadm to check if no new k8s version maps to a etcd version and just use the old one "25: 3.5.6-0"...but maybe i'm wrong.
this seems OK, i perhaps we still have to modify manually.
/lgtm
/approve
/milestone v1.26
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, pacoxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug |
/hold (pls remove hold if you agree with my above comment) |
yes, agree. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
/cc @neolit123
when I test v1.26.0-rc.1, I got this warning during init.
Should we add this like before to avoid the warning message? This would help when new version is released and new alpha version can work with a warning. But we still need to update it IMO.
Does this PR introduce a user-facing change?