pkg/kubeapiserver/options: Improving test coverage

[TommyStarK]

Signed-off-by: TommyStarK thomasmilox@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

If applied this commit will increase the unit tests code coverage of pkg/kubeapiserver/options

• Initial unit tests code coverage

• After changes

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Please note that we're already in Test Freeze for the release-1.26 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.26.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Dec 1 09:40:53 UTC 2022.

[k8s-ci-robot]

Hi @TommyStarK. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[TommyStarK]

Hello @cheftako, @liggitt

I know guys you are super busy and this PR is far from being a priority. As a very new aspiring contributor I am still trying to become familiar with the code and to start helping on small pieces. Hope you don't mind.

Any feedback will be greatly appreciated 😅.

Best regards,

[fedebongio]

/assign @deads2k @cici37 @jpbetz
/triage accepted

[jpbetz]

/lgtm

Test coverage increase looks great.

I did a pass on the tests and they made sense to me.

[k8s-ci-robot]

@TommyStarK: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aimuz]

/ok-to-test

[aimuz]

/lgtm

[TommyStarK]

Hello @jpbetz

Thank you for the review :) I updated my PR to correct the two misspelling that made the kubernetes-verify job to fail.

Best,

[TommyStarK]

@jpbetz , @aimuz

All pipelines have passed (except tide), don't hesitate if there is anything else I can do.

Best regards,

[jpbetz]

/lgtm
/assign @deads2k

[TommyStarK]

Hello @deads2k , @liggitt

@jpbetz Thank you very much for your time!

I know guys you are super busy and this is PR is far from a being a priority. Just wanted to give it a last try to get a review/approval.

Best regards,

[TommyStarK]

Hello @jpbetz

I updated my PR to include a suggestion made by @liggitt on another PR. Added a snippet of the expected error string related to the aspect being made invalid to ensure that the config is not getting rejected for an unrelated reason.

Remaining at your disposal.

Best regards,

[liggitt]

one question about the TTL changes, lgtm otherwise

[TommyStarK]

/retest-required

[liggitt]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt, TommyStarK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubeapiserver/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment