Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate ReadWriteOncePod to beta, updated e2e test #114494

Merged
merged 3 commits into from Feb 15, 2023

Conversation

chrishenzie
Copy link
Member

@chrishenzie chrishenzie commented Dec 14, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Graduates the ReadWriteOncePod feature from alpha to beta which now includes scheduler preemption handling for pods with this access mode. See #114051 for context. Updates the ReadWriteOncePod e2e test to handle the new behavior. Also updates the CSI hostpath driver to v1.11.0 which performs strict enforcement of the SINGLE_NODE_SINGLE_WRITER CSI access mode. See for more context:
kubernetes-csi/csi-driver-host-path#381

Which issue(s) this PR fixes:

Fixes #114493

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Graduate the `ReadWriteOncePod` feature gate to beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2485

/sig storage
/sig scheduling
/milestone v1.27
/cc @msau42
/cc @jsafrane
/cc @alculquicondor
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 14, 2022
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2022
@k8s-ci-robot
Copy link
Contributor

@chrishenzie: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

Graduates the ReadWriteOncePod feature from alpha to beta which now includes scheduler preemption handling for pods with this access mode. See #114051 for context. Blocking this PR until that (and KEP changes) are merged.

Which issue(s) this PR fixes:

Fixes #114493

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Sets the ReadWriteOncePod feature to beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2485

/sig storage
/sig scheduling
/milestone v1.27
/cc @msau42
/cc @jsafrane
/cc @alculquicondor
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 14, 2022
@k8s-ci-robot
Copy link
Contributor

@chrishenzie: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 14, 2022
@sftim
Copy link
Contributor

sftim commented Dec 14, 2022

Changelog text suggestion:

Graduate the `ReadWriteOncePod` feature gate to beta

@chrishenzie chrishenzie changed the title [v1.27] Bump ReadWriteOncePod to beta, updated e2e test [v1.27] Graduate ReadWriteOncePod to beta, updated e2e test Dec 15, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2023
@chrishenzie chrishenzie changed the title [v1.27] Graduate ReadWriteOncePod to beta, updated e2e test Graduate ReadWriteOncePod to beta, updated e2e test Feb 13, 2023
@chrishenzie
Copy link
Member Author

/hold cancel
/assign @msau42

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2023
@msau42
Copy link
Member

msau42 commented Feb 14, 2023

/retest

@msau42
Copy link
Member

msau42 commented Feb 14, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d0bfcea8342dcf61379c5645d9489af2a4f70215

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrishenzie, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 390ddaf into kubernetes:master Feb 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 15, 2023
@chrishenzie chrishenzie deleted the readwriteoncepod-beta branch February 15, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.27] Graduate the ReadWriteOncePod feature to beta
4 participants