Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for seccomp annotations when determining whether a container update should trigger a policy evaluation #114846

Merged
merged 1 commit into from Jan 10, 2023
Merged

Remove support for seccomp annotations when determining whether a container update should trigger a policy evaluation #114846

merged 1 commit into from Jan 10, 2023

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Jan 5, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Followup #109819, since the seccomp fields are immutable, so we can just drop them in 1.27

#109819 (comment)

container-level seccomp annotations could still influence 1.23 and 1.24 kubelets (which still honor them over pod level fields), so this is still a relevant change. keep this and leave a comment explaining why and a TODO to drop this in 1.27

Which issue(s) this PR fixes:

xref #95171

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@SataQiu
remove support for seccomp annotations when determining whether a con…
dbee23f 
…tainer update should trigger a policy evaluation
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 5, 2023
@k8s-ci-robot
Copy link
Contributor

@SataQiu: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 5, 2023
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 5, 2023
@SataQiu
Copy link
Member Author

SataQiu commented Jan 7, 2023

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Jan 9, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: efa70f2df7405516cbdcdb8d4c85a2af28e9b9b0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 78f2b1d into kubernetes:master Jan 10, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 10, 2023
@saschagrunert saschagrunert mentioned this pull request Jan 10, 2023
Merged
saschagrunert added a commit to saschagrunert/kubernetes that referenced this pull request Jan 12, 2023
@saschagrunert
Make seccomp annotations non-functional
af1f6a2 
This cleanup has been planned to finish the corresponding KEP:
kubernetes#91286

As follow-up on the partly removal of the seccomp annotations in
kubernetes#109819, we now drop
the version skew handling completely, but still warn as well as keep
the validation in place if both (annotation and field) are set.

The Pod Security Admission code has been already changed in
kubernetes#114846.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
danielvegamyhre pushed a commit to danielvegamyhre/kubernetes that referenced this pull request Jan 14, 2023
@saschagrunert @danielvegamyhre
Make seccomp annotations non-functional
b8e2971 
This cleanup has been planned to finish the corresponding KEP:
kubernetes#91286

As follow-up on the partly removal of the seccomp annotations in
kubernetes#109819, we now drop
the version skew handling completely, but still warn as well as keep
the validation in place if both (annotation and field) are set.

The Pod Security Admission code has been already changed in
kubernetes#114846.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SataQiu @k8s-ci-robot @liggitt @k8s-triage-robot