Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle event errors caused due to terminating namespaces #114849

Merged
merged 2 commits into from Jun 20, 2023
Merged

handle event errors caused due to terminating namespaces #114849

merged 2 commits into from Jun 20, 2023

Conversation

padlar
Copy link
Contributor

@padlar padlar commented Jan 5, 2023 •
edited

Signed-off-by: Sunil Shivanand sunil.shivanand@statnett.no

What type of PR is this?

/kind bug

What this PR does / why we need it:

Create events are forbidden in terminating namespaces, use info instead of error to log the failed event.

Which issue(s) this PR fixes:

Fixes #1208

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Users will no longer see an error for failed events caused due to terminating namespace.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 5, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @padlar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 5, 2023
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 5, 2023
@cici37
Copy link
Contributor

cici37 commented Jan 10, 2023

/assign @DangerOnTheRanger
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 10, 2023
@DangerOnTheRanger
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 11, 2023
@padlar
Copy link
Contributor Author

padlar commented Jan 11, 2023

/retest

@padlar padlar requested review from DangerOnTheRanger and removed request for coffeepac and logicalhan January 18, 2023 08:33
@erikgb
Copy link
Contributor

erikgb commented Feb 2, 2023

@DangerOnTheRanger any chance for another round of review on this one?

@DangerOnTheRanger
Copy link
Contributor

(sorry for the delay)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: df1fe8acefaf88fac91fc4de76387b54a4fbc9eb

@padlar
Copy link
Contributor Author

padlar commented Feb 28, 2023

@DangerOnTheRanger How do I get a approve label on this one?

@k8s-ci-robot k8s-ci-robot added do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 22, 2023
Sunil Shivanand added 2 commits March 22, 2023 13:51
handle event errors caused due to terminating namespaces
7a6d580 
Create events are forbidden in terminating namespaces, use info
instead of error to log the failed event.

Signed-off-by: Sunil Shivanand <sunil.shivanand@statnett.no>
combine conditional checks
80480f8 
Signed-off-by: Sunil Shivanand <sunil.shivanand@statnett.no>
@padlar padlar force-pushed the handle-terminating-namespaces branch from 1bc23e4 to 80480f8 Compare March 22, 2023 12:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Mar 22, 2023
@padlar
Copy link
Contributor Author

padlar commented Mar 22, 2023

/retest

@padlar
Copy link
Contributor Author

padlar commented Mar 22, 2023 •
edited

@DangerOnTheRanger adding release-note markdown marker removed LGTM label on this one. Could you reapply the label?

@DangerOnTheRanger
Copy link
Contributor

Sure thing

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 007b465c13bda516d5ae6c758250375bdd1f883e

@padlar
Copy link
Contributor Author

padlar commented Mar 22, 2023

/assign @ehashman

@padlar
Copy link
Contributor Author

padlar commented May 4, 2023

@ehashman Can we merge this one?

@padlar
Copy link
Contributor Author

padlar commented May 31, 2023

@cici37 this MR has been open for long, can we merge this?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, padlar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2e93c65 into kubernetes:master Jun 20, 2023
11 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 20, 2023
@erikgb
Copy link
Contributor

erikgb commented Jun 20, 2023

What are the policies for cherry-picking? Would it be possible to consider this a bug worth back-porting?

@dims
Copy link
Member

dims commented Jun 20, 2023

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@DangerOnTheRanger DangerOnTheRanger Awaiting requested review from DangerOnTheRanger

Assignees

@DangerOnTheRanger DangerOnTheRanger

@ehashman ehashman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

Should not log error when create event fails because of terminating namespace
7 participants
@padlar @k8s-ci-robot @cici37 @DangerOnTheRanger @erikgb @dims @ehashman