Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KMSv2] apiserver/kmsv2: mv Service interface into kmsv2 #114922

Merged
merged 1 commit into from Jan 17, 2023
Merged

[KMSv2] apiserver/kmsv2: mv Service interface into kmsv2 #114922

merged 1 commit into from Jan 17, 2023

Conversation

ibihim
Copy link
Contributor

@ibihim ibihim commented Jan 9, 2023

Signed-off-by: Krzysztof Ostrowski kostrows@redhat.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removes duplicate kms v2 service interface.

It got copied into k8s.io/kms as a first step and it is now being remove from k8s.io/apiserver (but imported).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP] https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/3299-kms-v2-improvements

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @ibihim. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 9, 2023
@ibihim ibihim changed the title apiserver/kmsv2: mv Service interface into kmsv2 [kms] apiserver/kmsv2: mv Service interface into kmsv2 Jan 9, 2023
@ibihim ibihim changed the title [kms] apiserver/kmsv2: mv Service interface into kmsv2 [KMSv2] apiserver/kmsv2: mv Service interface into kmsv2 Jan 9, 2023
@ibihim ibihim closed this Jan 9, 2023
@ibihim ibihim reopened this Jan 10, 2023
@enj
Copy link
Member

enj commented Jan 10, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 10, 2023
@cici37
Copy link
Contributor

cici37 commented Jan 10, 2023

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 10, 2023
@aramase
Copy link
Member

aramase commented Jan 11, 2023

/triage accepted
/cc

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 11, 2023
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 12, 2023
aramase
aramase reviewed Jan 12, 2023
View reviewed changes
staging/src/k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/envelope_test.go Outdated
@@ -30,6 +30,8 @@ import (
"k8s.io/apiserver/pkg/storage/value"
aestransformer "k8s.io/apiserver/pkg/storage/value/encrypt/aes"
kmstypes "k8s.io/apiserver/pkg/storage/value/encrypt/envelope/kmsv2/v2alpha1"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

aramase
aramase reviewed Jan 12, 2023
View reviewed changes
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nit!

pull-kubernetes-unit failure might just be a flake.

enj
enj suggested changes Jan 13, 2023
View reviewed changes
staging/src/k8s.io/apiserver/pkg/server/options/encryptionconfig/config.go Outdated
@@ -49,6 +49,7 @@ import (
"k8s.io/apiserver/pkg/storage/value/encrypt/identity"
"k8s.io/apiserver/pkg/storage/value/encrypt/secretbox"
utilfeature "k8s.io/apiserver/pkg/util/feature"
kmssvc "k8s.io/kms/service"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not 100% consistent about this but generally we use the last N segments when we want a better name (in this case N=2):

Suggested change
kmssvc "k8s.io/kms/service"
kmsservice "k8s.io/kms/service"

(applies to all the files)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! :) I am just slightly unhappy with the stutter kmsservice.Service. I wish I could come up with better naming.

@ibihim
apiserver/kmsv2: mv Service interface into kmsv2
b7701b0 
Signed-off-by: Krzysztof Ostrowski <kostrows@redhat.com>
@enj
Copy link
Member

enj commented Jan 17, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 289f4f626a7e502edfe52c06a75049330ef89a60

@dims
Copy link
Member

dims commented Jan 17, 2023

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, enj, ibihim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit f7b0226 into kubernetes:master Jan 17, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 17, 2023
@liggitt liggitt mentioned this pull request Mar 16, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase left review comments

@enj enj enj requested changes

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@dims dims

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Auth: KMS v2
Status: ✅ Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ibihim @k8s-ci-robot @enj @cici37 @aramase @dims