Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiserver cluster egress metrics: backport to release-1.24 #115561

Closed
wants to merge 4 commits into from
Closed

apiserver cluster egress metrics: backport to release-1.24 #115561

wants to merge 4 commits into from

Conversation

jkh52
Copy link
Contributor

@jkh52 jkh52 commented Feb 6, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  1. Backport apiserver metric related to cluster egress, to improve observability.

apiserver_egress_dialer_dial_start_total

  1. Register (related) new metrics added in konnectivity-client Bump Konnectivity to v0.0.35 in release-1.25 #114929

Which issue(s) this PR fixes:

Special notes for your reviewer:

Same PR for release-1.25 branch: #115041

No merge conflicts.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

jkh52 and others added 4 commits February 6, 2023 15:13
@jkh52
egress_selector.go: Add a dial starts metric.
29845f3 
Emit this metric before any potentially blocking dial work.
@logicalhan @jkh52
expose prometheus.Registerer so that we can hook into this from exter…
64e4331 
…nal sources

Change-Id: I0b4aa2218e309722a85143a50200e9e105020866
@jkh52
egress_selector.go: register konnectivity-client metrics.
ae4d6ba 
This registers new metrics provided by kubernetes#114789.
@jkh52
Fix konnectivity-client metric registration.
a7615d2
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 6, 2023
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 6, 2023
@k8s-ci-robot
Copy link
Contributor

This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)

For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 6, 2023
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 6, 2023
@jkh52
Copy link
Contributor Author

jkh52 commented Feb 6, 2023

/assign @logicalhan

logicalhan
logicalhan approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e54e1b0f49e499b6f6065039a90bd05dea65102b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jkh52, logicalhan
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval by writing /assign @sttts in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkh52
Copy link
Contributor Author

jkh52 commented Feb 7, 2023

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team February 7, 2023 00:24
@cici37
Copy link
Contributor

cici37 commented Feb 7, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 7, 2023
@jkh52 jkh52 mentioned this pull request Feb 16, 2023
Closed
@jkh52
Copy link
Contributor Author

jkh52 commented Mar 13, 2023

friendly ping.

/assign @Verolop

@jkh52
Copy link
Contributor Author

jkh52 commented Apr 12, 2023

/assign @liggitt

@jkh52
Copy link
Contributor Author

jkh52 commented Apr 13, 2023

Closing, similar to #115041

@jkh52 jkh52 closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@sttts sttts Awaiting requested review from sttts

Assignees

@logicalhan logicalhan

@liggitt liggitt

@Verolop Verolop

Labels
area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jkh52 @k8s-ci-robot @cici37 @logicalhan @liggitt @Verolop