Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webhook metrics top out at 2.5s but default timeout is 10s #115802

Merged
merged 2 commits into from Feb 15, 2023
Merged

webhook metrics top out at 2.5s but default timeout is 10s #115802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20b5205
use 10 seconds as the biggest bucket for webhook metrics otherwise ch…
logicalhan Feb 15, 2023
7b82300
add 25s bucket
logicalhan Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go
View file
Open in desktop
Expand Up @@ -178,7 +178,7 @@ func newAdmissionMetrics() *AdmissionMetrics {
Subsystem: subsystem,
Name: "webhook_admission_duration_seconds",
Help: "Admission webhook latency histogram in seconds, identified by name and broken out for each operation and API resource and type (validate or admit).",
Buckets: []float64{0.005, 0.025, 0.1, 0.5, 1.0, 2.5},
Buckets: []float64{0.005, 0.025, 0.1, 0.5, 1.0, 2.5, 10, 25},
StabilityLevel: metrics.STABLE,
},
[]string{"name", "type", "operation", "rejected"},
Expand Down
2 changes: 2 additions & 0 deletions test/instrumentation/testdata/stable-metrics-list.yaml
View file
Open in desktop
Expand Up @@ -290,6 +290,8 @@
- 0.5
- 1
- 2.5
- 10
- 25
- name: current_inflight_requests
subsystem: apiserver
help: Maximal number of currently used inflight request limit of this apiserver
Expand Down