Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deflake tests in staging/src/k8s.io/kube-aggregator/pkg/apiserver #115859

Merged
merged 2 commits into from Mar 1, 2023
Merged

Deflake tests in staging/src/k8s.io/kube-aggregator/pkg/apiserver #115859

merged 2 commits into from Mar 1, 2023

Commits on Mar 1, 2023

  1. Fix a data race in TestDirty 

    This uses atomic.Bool as updating and reading a boolean-type variable
concurrently is not thread-safe.
    @gjkim42
    gjkim42 committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    e7d8dfb View commit details
    Browse the repository at this point in the history

  2. Deflake tests in staging/src/k8s.io/kube-aggregator/pkg/apiserver 

    `waitForEmptyQueue` cannot guarantee that all items in the queue have
been synced completely but guarantee that all items have been started.

This adds `waitForQueueComplete` and implements `completerWorkqueue` to
check if the workqueue is complete to deflake the tests in
staging/src/k8s.io/kube-aggregator/pkg/apiserver.
    @gjkim42
    gjkim42 committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    e24e3de View commit details
    Browse the repository at this point in the history