-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #115770: Fix legacy fallback stale for aggregated discovery #115971
Automated cherry pick of #115770: Fix legacy fallback stale for aggregated discovery #115971
Conversation
This cherry pick PR is for a release branch and has not yet been approved by Release Managers. To merge this cherry pick, it must first be approved ( AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers (This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.) For details on the patch release process and schedule, see the Patch Releases page. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @Jefftree |
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Note that tests will be failing until #115805 cherry pick is merged. |
The UT flakes in https://storage.googleapis.com/k8s-triage/index.html?text=TestLegacyFallbackNoCache#1bf2be60ce0078971afe
|
/triage accepted |
now that patch releases are out, would be good to get the bug/test fixes for aggregated discovery backported... I asked in #115805 (comment) if there were other master fixes needed, and if it would make sense to consolidate into a single PR to make sure we don't miss anything or hit ordering conflicts |
now included in https://github.com/kubernetes/kubernetes/pull/115805/commits |
Cherry pick of #115770 on release-1.26.
#115770: Fix legacy fallback stale for aggregated discovery
For details on the cherry pick process, see the cherry pick requests page.