Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(hpa): beta graduation for the container resource metrics #116046

Merged
merged 1 commit into from Mar 15, 2023
Merged

feature(hpa): beta graduation for the container resource metrics #116046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions pkg/features/kube_features.go
View file
Open in desktop
Expand Up @@ -314,8 +314,10 @@ const (
// Make the kubelet use shutdown configuration based on pod priority values for graceful shutdown.
GracefulNodeShutdownBasedOnPodPriority featuregate.Feature = "GracefulNodeShutdownBasedOnPodPriority"

// owner: @arjunrn @mwielgus @josephburnett
// owner: @arjunrn @mwielgus @josephburnett @sanposhiho
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: Can we add the link to the KEP in whilst we're here, as per: https://github.com/kubernetes/kubernetes/blob/067b8a80255de4e1d6d51c6eae525c1e673eb01c/pkg/features/kube_features.go#L30

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Fixed.

// kep: https://kep.k8s.io/1610
// alpha: v1.20
// beta: v1.27
//
// Add support for the HPA to scale based on metrics from individual containers
// in target pods
Expand Down Expand Up @@ -923,7 +925,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS

GracefulNodeShutdownBasedOnPodPriority: {Default: true, PreRelease: featuregate.Beta},

HPAContainerMetrics: {Default: false, PreRelease: featuregate.Alpha},
HPAContainerMetrics: {Default: true, PreRelease: featuregate.Beta},

HonorPVReclaimPolicy: {Default: false, PreRelease: featuregate.Alpha},

Expand Down