Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #115907: svc: Support pods with same address #116084

Conversation

qinqon
Copy link
Contributor

@qinqon qinqon commented Feb 27, 2023

Cherry pick of #115907 on release-1.26.

#115907: svc: Support pods with same address

For details on the cherry pick process, see the cherry pick requests page.


@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Feb 27, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @qinqon. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 27, 2023
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Feb 27, 2023
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 27, 2023
@qinqon
Copy link
Contributor Author

qinqon commented Feb 27, 2023

/cc @aojea @robscott

@aojea
Copy link
Member

aojea commented Feb 27, 2023

/ok-to-test
/lgtm
/assign @robscott

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 37d7d98295809da149a33f8a01b54e336e9131a7

If different pods with same address are exposed by the same service if
some of the endpointslices endpoints are overwriten. This change add the
pod name to the hash function to ensure that all the endpoints are in
place.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon qinqon force-pushed the automated-cherry-pick-of-#115907-origin-release-1.26 branch from d2ac302 to 9ec50f5 Compare February 27, 2023 09:58
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023
@aojea
Copy link
Member

aojea commented Feb 27, 2023

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a8e12a8a5c133a15bc6ae80d37767b446b666dd1

@aojea
Copy link
Member

aojea commented Feb 27, 2023

 TestRemoveAPIService
I0227 10:27:08.743654   84139 handler.go:149] Adding GroupVersion 摾Lʉĥ峡拓 凣OC瓴业ǯSfĹdzƘ繙e to ResourceManager
I0227 10:27:08.743922   84139 handler.go:149] Adding GroupVersion 摾Lʉĥ峡拓 ɰ薗w2;3 to ResourceManager
I0227 10:27:08.744042   84139 handler.go:149] Adding GroupVersion 摾Lʉĥ峡拓 ȵʭ洒$\' to ResourceManager
I0227 10:27:08.744171   84139 handler.go:149] Adding GroupVersion 摾Lʉĥ峡拓 壊3囜n繊ŀ槉@ to ResourceManager
I0227 10:27:08.744276   84139 handler.go:149] Adding GroupVersion z,劚ƒqiM7婼<7圾º Hľȋ?{ə%ĺ誟ǀ還N儮 to ResourceManager
I0227 10:27:08.744427   84139 handler.go:149] Adding GroupVersion z,劚ƒqiM7婼<7圾º ǭȐÿ to ResourceManager
I0227 10:27:08.744539   84139 handler.go:149] Adding GroupVersion z,劚ƒqiM7婼<7圾º 闀8ǿ滃 to ResourceManager
I0227 10:27:08.744661   84139 handler.go:149] Adding GroupVersion z,劚ƒqiM7婼<7圾º 覒ęȽ鉹鏪_败>ŵx¤蕰 to ResourceManager
I0227 10:27:08.745179   84139 handler_discovery.go:403] Starting ResourceDiscoveryManager
I0227 10:27:08.769440   84139 handler.go:149] Adding GroupVersion 摾Lʉĥ峡拓 凣OC瓴业ǯSfĹdzƘ繙e to ResourceManager
I0227 10:27:08.769709   84139 handler.go:149] Adding GroupVersion 摾Lʉĥ峡拓 ȵʭ洒$\' to ResourceManager
I0227 10:27:08.769876   84139 handler.go:149] Adding GroupVersion 摾Lʉĥ峡拓 壊3囜n繊ŀ槉@ to ResourceManager
I0227 10:27:08.770008   84139 handler.go:149] Adding GroupVersion z,劚ƒqiM7婼<7圾º Hľȋ?{ə%ĺ誟ǀ還N儮 to ResourceManager
I0227 10:27:08.770138   84139 handler.go:149] Adding GroupVersion z,劚ƒqiM7婼<7圾º ǭȐÿ to ResourceManager
I0227 10:27:08.770265   84139 handler.go:149] Adding GroupVersion z,劚ƒqiM7婼<7圾º 闀8ǿ滃 to ResourceManager
I0227 10:27:08.770394   84139 handler.go:149] Adding GroupVersion z,劚ƒqiM7婼<7圾º 覒ęȽ鉹鏪_败>ŵx¤蕰 to ResourceManager
    handler_discovery_test.go:203: expected to find no groups after service deletion (got 2 groups)

/test pull-kubernetes-unit

I see this happen before 👀

@aojea
Copy link
Member

aojea commented Feb 27, 2023

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 27, 2023
@aojea
Copy link
Member

aojea commented Mar 1, 2023

/approve
Rob is on vacation these days

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, qinqon, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 3, 2023
@saschagrunert
Copy link
Member

@k8s-ci-robot k8s-ci-robot merged commit 2dae34c into kubernetes:release-1.26 Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants