New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #115907: svc: Support pods with same address #116084
Automated cherry pick of #115907: svc: Support pods with same address #116084
Conversation
Hi @qinqon. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
LGTM label has been added. Git tree hash: 37d7d98295809da149a33f8a01b54e336e9131a7
|
If different pods with same address are exposed by the same service if some of the endpointslices endpoints are overwriten. This change add the pod name to the hash function to ensure that all the endpoints are in place. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
d2ac302
to
9ec50f5
Compare
/lgtm backport conflicts with the |
LGTM label has been added. Git tree hash: a8e12a8a5c133a15bc6ae80d37767b446b666dd1
|
/test pull-kubernetes-unit I see this happen before 👀 |
/kind bug |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, qinqon, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #115907 on release-1.26.
#115907: svc: Support pods with same address
For details on the cherry pick process, see the cherry pick requests page.