Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turn field validation e2e tests into conformance tests #116111

Merged
merged 1 commit into from Feb 28, 2023
Merged

turn field validation e2e tests into conformance tests #116111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
49 changes: 49 additions & 0 deletions test/conformance/testdata/conformance.yaml
View file
Open in desktop
Expand Up @@ -319,6 +319,55 @@
return a valid PreferredVersion unless the group suffix is example.com.
release: v1.19
file: test/e2e/apimachinery/discovery.go
- testname: Server side field validation, unknown fields CR no validation schema
codename: '[sig-api-machinery] FieldValidation should create/apply a CR with unknown
fields for CRD with no validation schema [Conformance]'
description: When a CRD does not have a validation schema, it should succeed when
a CR with unknown fields is applied.
release: v1.27
file: test/e2e/apimachinery/field_validation.go
- testname: Server side field validation, valid CR with validation schema
codename: '[sig-api-machinery] FieldValidation should create/apply a valid CR for
CRD with validation schema [Conformance]'
description: When a CRD has a validation schema, it should succeed when a valid
CR is applied.
release: v1.27
file: test/e2e/apimachinery/field_validation.go
- testname: Server side field validation, unknown fields CR fails validation
codename: '[sig-api-machinery] FieldValidation should create/apply an invalid CR
with extra properties for CRD with validation schema [Conformance]'
description: When a CRD does have a validation schema, it should reject CRs with
unknown fields.
release: v1.27
file: test/e2e/apimachinery/field_validation.go
- testname: Server side field validation, CR duplicates
codename: '[sig-api-machinery] FieldValidation should detect duplicates in a CR
when preserving unknown fields [Conformance]'
description: The server should reject CRs with duplicate fields even when preserving
unknown fields.
release: v1.27
file: test/e2e/apimachinery/field_validation.go
- testname: Server side field validation, typed object
codename: '[sig-api-machinery] FieldValidation should detect unknown and duplicate
fields of a typed object [Conformance]'
description: It should reject the request if a typed object has unknown or duplicate
fields.
release: v1.27
file: test/e2e/apimachinery/field_validation.go
- testname: Server side field validation, unknown metadata
codename: '[sig-api-machinery] FieldValidation should detect unknown metadata fields
in both the root and embedded object of a CR [Conformance]'
description: The server should reject CRs with unknown metadata fields in both the
root and embedded objects of a CR.
release: v1.27
file: test/e2e/apimachinery/field_validation.go
- testname: Server side field validation, typed unknown metadata
codename: '[sig-api-machinery] FieldValidation should detect unknown metadata fields
of a typed object [Conformance]'
description: It should reject the request if a typed object has unknown fields in
the metadata.
release: v1.27
file: test/e2e/apimachinery/field_validation.go
- testname: Garbage Collector, delete deployment, propagation policy background
codename: '[sig-api-machinery] Garbage collector should delete RS created by deployment
when not orphaning [Conformance]'
Expand Down
14 changes: 7 additions & 7 deletions test/e2e/apimachinery/field_validation.go
View file
Open in desktop
Expand Up @@ -61,7 +61,7 @@ var _ = SIGDescribe("FieldValidation", func() {
Testname: Server side field validation, typed object
Description: It should reject the request if a typed object has unknown or duplicate fields.
*/
ginkgo.It("should detect unknown and duplicate fields of a typed object", func(ctx context.Context) {
framework.ConformanceIt("should detect unknown and duplicate fields of a typed object", func(ctx context.Context) {
ginkgo.By("apply creating a deployment")
invalidMetaDeployment := `{
"apiVersion": "apps/v1",
Expand Down Expand Up @@ -114,7 +114,7 @@ var _ = SIGDescribe("FieldValidation", func() {
Testname: Server side field validation, typed unknown metadata
Description: It should reject the request if a typed object has unknown fields in the metadata.
*/
ginkgo.It("should detect unknown metadata fields of a typed object", func(ctx context.Context) {
framework.ConformanceIt("should detect unknown metadata fields of a typed object", func(ctx context.Context) {
ginkgo.By("apply creating a deployment")
invalidMetaDeployment := `{
"apiVersion": "apps/v1",
Expand Down Expand Up @@ -165,7 +165,7 @@ var _ = SIGDescribe("FieldValidation", func() {
Testname: Server side field validation, valid CR with validation schema
Description: When a CRD has a validation schema, it should succeed when a valid CR is applied.
*/
ginkgo.It("should create/apply a valid CR for CRD with validation schema", func(ctx context.Context) {
framework.ConformanceIt("should create/apply a valid CR for CRD with validation schema", func(ctx context.Context) {
config, err := framework.LoadConfig()
if err != nil {
framework.Failf("%s", err)
Expand Down Expand Up @@ -283,7 +283,7 @@ spec:
Testname: Server side field validation, unknown fields CR no validation schema
Description: When a CRD does not have a validation schema, it should succeed when a CR with unknown fields is applied.
*/
ginkgo.It("should create/apply a CR with unknown fields for CRD with no validation schema", func(ctx context.Context) {
framework.ConformanceIt("should create/apply a CR with unknown fields for CRD with no validation schema", func(ctx context.Context) {
config, err := framework.LoadConfig()
if err != nil {
framework.Failf("%s", err)
Expand Down Expand Up @@ -341,7 +341,7 @@ spec:
Testname: Server side field validation, unknown fields CR fails validation
Description: When a CRD does have a validation schema, it should reject CRs with unknown fields.
*/
ginkgo.It("should create/apply an invalid CR with extra properties for CRD with validation schema", func(ctx context.Context) {
framework.ConformanceIt("should create/apply an invalid CR with extra properties for CRD with validation schema", func(ctx context.Context) {
config, err := framework.LoadConfig()
if err != nil {
framework.Failf("%s", err)
Expand Down Expand Up @@ -462,7 +462,7 @@ spec:
Description: The server should reject CRs with unknown metadata fields in both the root and embedded objects
of a CR.
*/
ginkgo.It("should detect unknown metadata fields in both the root and embedded object of a CR", func(ctx context.Context) {
framework.ConformanceIt("should detect unknown metadata fields in both the root and embedded object of a CR", func(ctx context.Context) {
config, err := framework.LoadConfig()
if err != nil {
framework.Failf("%s", err)
Expand Down Expand Up @@ -607,7 +607,7 @@ spec:
Testname: Server side field validation, CR duplicates
Description: The server should reject CRs with duplicate fields even when preserving unknown fields.
*/
ginkgo.It("should detect duplicates in a CR when preserving unknown fields", func(ctx context.Context) {
framework.ConformanceIt("should detect duplicates in a CR when preserving unknown fields", func(ctx context.Context) {
config, err := framework.LoadConfig()
if err != nil {
framework.Failf("%s", err)
Expand Down