Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip special features in TestPodSecurityGAOnly #116153

Merged
merged 1 commit into from Mar 1, 2023
Merged

skip special features in TestPodSecurityGAOnly #116153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/integration/auth/podsecurity_test.go
View file
Open in desktop
Expand Up @@ -75,7 +75,11 @@ func TestPodSecurity(t *testing.T) {
func TestPodSecurityGAOnly(t *testing.T) {
// Disable all alpha and beta features
for k, v := range utilfeature.DefaultFeatureGate.DeepCopy().GetAll() {
if v.PreRelease == featuregate.Alpha || v.PreRelease == featuregate.Beta {
if k == "AllAlpha" || k == "AllBeta" {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also considered just copying & swapping out the entire utilfeature.DefaultFeatureGate but that cannot be done atomically, not sure if that is a consideration in the test environment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine for now, I'll open a follow up to make SetFeatureGateDuringTest safe no matter what you throw at it

// Skip special features. When processed first, special features may
// erroneously disable other features.
continue
} else if v.PreRelease == featuregate.Alpha || v.PreRelease == featuregate.Beta {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, k, false)()
}
}
Expand Down