Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WinProxy] Adding additional validations to queried endpoint list iteration. #116749

Merged

Conversation

princepereira
Copy link
Contributor

@princepereira princepereira commented Mar 20, 2023

What type of PR is this?

/kind cleanup
/kind regression

What this PR does / why we need it:

This PR adds additional validation to check if the endpoints queried from the nodes are with IpConfigurations.

Which issue(s) this PR fixes:

If the queried endpoints are with out any IpConfigurations, then it will end up in index out of bound exceptions which can create continuous crashing of kubeproxy.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix 1.25 regression in WinProxy sync to handle queried endpoints without any IpConfigurations

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/sig windows
/sig network
/test pull-kubernetes-e2e-capz-windows-containerd-1-24

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/regression Categorizes issue or PR as related to a regression from a prior release. sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 20, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @princepereira. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@princepereira: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

…ration.

What type of PR is this?

/kind cleanup
/kind regression

What this PR does / why we need it:

This PR adds additional validation to check if the endpoints queried from the nodes are with IpConfigurations.

Which issue(s) this PR fixes:

If the queried endpoints are with out any IpConfigurations, then it will end up in index out of bound exceptions which can create continuous crashing of kubeproxy.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

This PR adds additional validation for endpoint ip configuration while iterating through queried endpoint list.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/sig windows
/sig network
/test pull-kubernetes-e2e-capz-windows-containerd-1-24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbangari
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2023
@sbangari
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: princepereira, sbangari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1318d0a7998efa1fb4021ffb5ab173133551c667

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit d107037 into kubernetes:master Apr 12, 2023
1 check passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 12, 2023
k8s-ci-robot added a commit that referenced this pull request Jul 12, 2023
…f-#116749-upstream-release-1.26

Automated cherry pick of #116749: Adding additional validations to queried endpoint
k8s-ci-robot added a commit that referenced this pull request Jul 12, 2023
…f-#116749-upstream-release-1.25

Automated cherry pick of #116749: Adding additional validations to queried endpoint
k8s-ci-robot added a commit that referenced this pull request Jul 12, 2023
…f-#116749-upstream-release-1.27

Automated cherry pick of #116749: Adding additional validations to queried endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants