Swich to new gcloud API for GCE MIGs #11692

wojtek-t · 2015-07-22T14:06:59Z

k8s-bot · 2015-07-22T14:11:39Z

GCE e2e build/test failed for commit 632f1d74443d1948d5750e9a5329db622245053e.

roberthbailey · 2015-07-22T14:17:33Z

cluster/gce/util.sh

-  # command returns, but currently it returns before the instances come up due
-  # to gcloud's deficiency.
-  wait-for-minions-to-run
+  gcloud beta compute instance-groups managed wait-until-stable "${NODE_INSTANCE_PREFIX}-group"


does this need || true at the end in case of errors? or some other error checking?

roberthbailey · 2015-07-22T14:19:00Z

@wojtek-t why did you mark this as do not merge?

wojtek-t · 2015-07-22T14:21:52Z

@roberthbailey - the new API is not yet released (should be today according to MIG team from Warsaw) - this is why Jenkins tests failed. [I've tested by updating my gcloud to (still) experimental version]

wojtek-t · 2015-07-22T14:22:23Z

[by new API I mean support for it in gcloud]

roberthbailey · 2015-07-22T14:27:20Z

Ah. I know that the new raw API is out already; I didn't realize gcloud support hadn't rolled out yet.

k8s-bot · 2015-07-22T14:29:27Z

GCE e2e build/test failed for commit bc4c526a4400035d8af8812f62ba6ab524e54e27.

k8s-bot · 2015-07-23T11:15:23Z

GCE e2e build/test failed for commit 247cf8faa56debaef38bf467780cedcbc0e0e151.

wojtek-t · 2015-07-23T11:17:36Z

Jenkins is now failing with the following error:

You do not currently have this command group installed.  Using it requires the installation of components: [beta]
ERROR: (gcloud) You cannot perform this action because you do not have permission to modify the Google Cloud SDK installation directory [/usr/local/share/google/google-cloud-sdk].

How can we workaround it (and do we want?)?

roberthbailey · 2015-07-23T16:14:09Z

/cc @jlowdermilk

j3ffml · 2015-07-23T16:28:37Z

It looks like the beta component actually is installed for shared gcloud. Maybe someone recently bumped it? @k8s-bot retest this please

mikedanese · 2015-07-23T20:52:00Z

Please reassign when this is ready to merge.

k8s-bot · 2015-07-27T10:47:14Z

GCE e2e build/test failed for commit 59962376f6e7c77a6d0a4d11d0be0d90fb391d04.

k8s-bot · 2015-07-30T12:44:20Z

GCE e2e build/test failed for commit 92623bcdcf4ff930315e4e97110be371c48986d6.

k8s-bot · 2015-07-30T12:57:20Z

GCE e2e build/test failed for commit ef9f6c72de45151142061fe1f99eee61a3e840ef.

wojtek-t · 2015-07-30T12:59:57Z

@jlowdermilk (sorry for late response). It seems that beta is not installed - i.e. after rebasing today it's still not there. Is there any way to work around it? Is it possible to proceed with that change?

j3ffml · 2015-07-30T17:40:16Z

@wojtek-t, sorry I was looking at the wrong project. I don't have access to the pr builder jenkins master to install the beta component, but I've pinged @ixdy, and will update it shortly.

j3ffml · 2015-07-30T18:09:15Z

@k8s-bot test this please

k8s-bot · 2015-07-30T18:24:54Z

GCE e2e build/test failed for commit ef9f6c72de45151142061fe1f99eee61a3e840ef.

wojtek-t · 2015-07-31T06:33:47Z

@wojtek-t, sorry I was looking at the wrong project. I don't have access to the pr builder jenkins master to install the beta component, but I've pinged @ixdy, and will update it shortly.

@ixdy - did you have chance to look into it?

k8s-bot · 2015-07-31T07:20:42Z

GCE e2e build/test failed for commit ff9292509de6c3d03395ff909264373f24c0ea0c.

k8s-bot · 2015-07-31T07:32:40Z

GCE e2e build/test failed for commit ef189bbb1cde4b961fee5fe1649c4051eee17a21.

k8s-bot · 2015-07-31T08:02:43Z

GCE e2e build/test passed for commit 74a73511767e7f2e336442459436c50433ce4e58.

wojtek-t · 2015-07-31T08:37:21Z

This is now ready for review.

wojtek-t · 2015-07-31T08:37:48Z

@roberthbailey - can you please take a look (or delegate)?

roberthbailey · 2015-07-31T16:29:33Z

cluster/gce/util.sh

@@ -695,16 +677,16 @@ function kube-up {
  write-node-env
  create-node-instance-template

-  gcloud preview managed-instance-groups --zone "${ZONE}" \
+  gcloud beta compute instance-groups managed \


When I tested a similar command yesterday this was working for me without the 'beta' cmd group, so I think we can remove that from the script.

Yes - it seems to work now.

Done.

roberthbailey · 2015-07-31T16:31:59Z

LGTM, but I think we should use gcloud compute instance-groups rather than gcloud beta compute instance-groups in all of these commands.

ixdy · 2015-07-31T23:18:30Z

cluster/gce/util.sh

-  # command returns, but currently it returns before the instances come up due
-  # to gcloud's deficiency.
-  wait-for-minions-to-run
+  gcloud beta compute instance-groups managed wait-until-stable \


probably need --project here too

That's not needed, but I've added it for consistency.

k8s-bot · 2015-08-03T08:15:11Z

GCE e2e build/test passed for commit 2d95cd4.

wojtek-t · 2015-08-03T08:16:53Z

@roberthbailey - PTAL

roberthbailey · 2015-08-03T16:48:39Z

LGTM.

roberthbailey · 2015-08-03T16:49:51Z

@wojtek-t Please cherry pick this into the 1.0 release branch (after it's been merged) so that our release branch validation tests are using the current API for MIGs as well (I doubt the preview commands will work for much longer).

brendandburns · 2015-08-03T17:48:36Z

@k8s-bot test this [testing build queue, sorry for the noise]

k8s-bot · 2015-08-03T18:07:32Z

GCE e2e build/test passed for commit 2d95cd4.

brendandburns · 2015-08-03T18:07:36Z

Automatic merge from SubmitQueue

Auto commit by PR queue bot

…92-upstream-release-1.0 Auto commit by PR queue bot

googlebot added the cla: yes label Jul 22, 2015

roberthbailey reviewed Jul 22, 2015
View reviewed changes

wojtek-t force-pushed the new_api_instance_groups branch from 632f1d7 to bc4c526 Compare July 22, 2015 14:24

wojtek-t force-pushed the new_api_instance_groups branch from bc4c526 to 247cf8f Compare July 23, 2015 11:09

mikedanese assigned wojtek-t Jul 23, 2015

wojtek-t force-pushed the new_api_instance_groups branch from 247cf8f to 5996237 Compare July 27, 2015 10:42

wojtek-t force-pushed the new_api_instance_groups branch from 5996237 to 92623bc Compare July 30, 2015 12:42

wojtek-t force-pushed the new_api_instance_groups branch from 92623bc to ef9f6c7 Compare July 30, 2015 12:49

wojtek-t force-pushed the new_api_instance_groups branch from ef9f6c7 to ff92925 Compare July 31, 2015 07:18

wojtek-t force-pushed the new_api_instance_groups branch from ff92925 to ef189bb Compare July 31, 2015 07:25

wojtek-t force-pushed the new_api_instance_groups branch from ef189bb to 74a7351 Compare July 31, 2015 07:44

wojtek-t changed the title ~~[Do NOT merge] Swich to new gcloud API for GCE MIGs~~ Swich to new gcloud API for GCE MIGs Jul 31, 2015

wojtek-t assigned roberthbailey and unassigned wojtek-t Jul 31, 2015

roberthbailey reviewed Jul 31, 2015
View reviewed changes

ixdy reviewed Jul 31, 2015
View reviewed changes

Swich to new gcloud API for GCE MIGs

2d95cd4

wojtek-t force-pushed the new_api_instance_groups branch from 74a7351 to 2d95cd4 Compare August 3, 2015 07:56

roberthbailey added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2015

brendandburns added a commit that referenced this pull request Aug 3, 2015

Merge pull request #11692 from wojtek-t/new_api_instance_groups

2e68002

Auto commit by PR queue bot

brendandburns merged commit 2e68002 into kubernetes:master Aug 3, 2015

wojtek-t deleted the new_api_instance_groups branch August 4, 2015 08:44

alex-mohr referenced this pull request Aug 4, 2015

Merge pull request #12192 from wojtek-t/automated-cherry-pick-of-#116…

15cf794

…92-upstream-release-1.0 Auto commit by PR queue bot

brendandburns mentioned this pull request Aug 7, 2015

Release 1.0.3 #12382

Merged

roberthbailey mentioned this pull request Aug 11, 2015

Fix kube-push using gcloud compute instance-groups managed set-instance-template #12541

Merged

roberthbailey mentioned this pull request Aug 18, 2015

Migrate test infrastructure to new gcloud commands for MIGs #12881

Closed

Swich to new gcloud API for GCE MIGs #11692

Swich to new gcloud API for GCE MIGs #11692

Conversation

wojtek-t commented Jul 22, 2015

k8s-bot commented Jul 22, 2015

roberthbailey Jul 22, 2015

Choose a reason for hiding this comment

wojtek-t Jul 22, 2015

Choose a reason for hiding this comment

roberthbailey commented Jul 22, 2015

wojtek-t commented Jul 22, 2015

wojtek-t commented Jul 22, 2015

roberthbailey commented Jul 22, 2015

k8s-bot commented Jul 22, 2015

k8s-bot commented Jul 23, 2015

wojtek-t commented Jul 23, 2015

roberthbailey commented Jul 23, 2015

j3ffml commented Jul 23, 2015

mikedanese commented Jul 23, 2015

k8s-bot commented Jul 27, 2015

k8s-bot commented Jul 30, 2015

k8s-bot commented Jul 30, 2015

wojtek-t commented Jul 30, 2015

j3ffml commented Jul 30, 2015

j3ffml commented Jul 30, 2015

k8s-bot commented Jul 30, 2015

wojtek-t commented Jul 31, 2015

k8s-bot commented Jul 31, 2015

k8s-bot commented Jul 31, 2015

k8s-bot commented Jul 31, 2015

wojtek-t commented Jul 31, 2015

wojtek-t commented Jul 31, 2015

roberthbailey Jul 31, 2015

Choose a reason for hiding this comment

wojtek-t Aug 3, 2015

Choose a reason for hiding this comment

roberthbailey commented Jul 31, 2015

ixdy Jul 31, 2015

Choose a reason for hiding this comment

wojtek-t Aug 3, 2015

Choose a reason for hiding this comment

k8s-bot commented Aug 3, 2015

wojtek-t commented Aug 3, 2015

roberthbailey commented Aug 3, 2015

roberthbailey commented Aug 3, 2015

brendandburns commented Aug 3, 2015

k8s-bot commented Aug 3, 2015

brendandburns commented Aug 3, 2015