Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove CSI-migration gate #117055

Merged
merged 1 commit into from Jun 28, 2023
Merged

remove CSI-migration gate #117055

merged 1 commit into from Jun 28, 2023

Conversation

cyclinder
Copy link
Contributor

@cyclinder cyclinder commented Apr 3, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As a part of #114068, We do CSI-migration gate removals in this PR.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The feature gates `CSIMigrationGCE` is graduated to GA and were unconditionally enabled have been removed in v1.25, and the entire gcepd package has been removed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.27 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.27.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Apr 2 22:34:42 UTC 2023.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 3, 2023
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 3, 2023
@cyclinder cyclinder mentioned this pull request Apr 3, 2023
Merged
@cyclinder
Copy link
Contributor Author

/test pull-kubernetes-unit

1 similar comment
@cyclinder
Copy link
Contributor Author

/test pull-kubernetes-unit

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Apr 3, 2023
@haosdent
Copy link
Member

haosdent commented Apr 4, 2023

Which issue(s) this PR fixes:
Fixes #

Need to link to the correct issue? @cyclinder

@cyclinder
Copy link
Contributor Author

Need to link to the correct issue?

This PR does not have an issue to fix. Just to complete the cleanup of csi-migration gate, the original request originated from #114068 (comment)

@haosdent
Copy link
Member

haosdent commented Apr 4, 2023

Got it, @cyclinder

@haosdent
Copy link
Member

haosdent commented Apr 4, 2023

LGTM

@cici37
Copy link
Contributor

cici37 commented Apr 4, 2023

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 4, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Apr 6, 2023

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 6, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jun 4, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jun 4, 2023
@cyclinder
Copy link
Contributor Author

/retest

@cyclinder
Copy link
Contributor Author

Thanks this is looking good. Can you update the release note now that only one feature gate is being removed?

Sure, updated now

@cyclinder
Copy link
Contributor Author

/retest

@cyclinder
Copy link
Contributor Author

/test pull-kubernetes-e2e-storage-kind-disruptive

@cyclinder
Copy link
Contributor Author

PR has been ready, Please take a review, Thanks.

/cc @msau42 @xing-yang @humblec

@humblec
Copy link
Contributor

humblec commented Jun 16, 2023

This looks good to me and thanks for parking the test case on fake plugin 👍

@cyclinder
Copy link
Contributor Author

hi @humblec @msau42 @xing-yang is this lgtm from your perspective now?

@hailkomputer
Copy link
Member

Hello! Bug triage team shadow here. I want to check the status. The code freeze is starting 01:00 UTC Wednesday 19th July 2023 / 18:00 PDT Tuesday 18th July 2023 (about three weeks from now), and while there is still plenty of time, we want to ensure that each PR has a chance to be merged on time.

As the PR is tagged for 1.28, is it still planned for this release?

@cyclinder
Copy link
Contributor Author

thanks @hailkomputer

Yes, I think the PR is time to merge. but I need ack for csi reviewers.(..sad)

/cc @dims please help, thanks

@msau42
Copy link
Member

msau42 commented Jun 27, 2023 •
edited

@cyclinder sorry the delay. Can you remove the references to Azure feature gates from the release note? It looks like this PR is only modifying GCE PD.

/lgtm
/approve
/hold

to fix release note

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 92ac8323ad73da62dbe0827c64387866b0cfa85e

@cyclinder
Copy link
Contributor Author

thanks @msau42 ❤️

@msau42
Copy link
Member

msau42 commented Jun 28, 2023

/assign @dims

@dims
Copy link
Member

dims commented Jun 28, 2023

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyclinder, dims, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5245784 into kubernetes:master Jun 28, 2023
16 of 17 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done Jun 28, 2023
@mengjiao-liu mengjiao-liu mentioned this pull request Aug 3, 2023
Merged
@honcao honcao mentioned this pull request Jan 3, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcary mattcary mattcary left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@msau42 msau42 Awaiting requested review from msau42

@liggitt liggitt Awaiting requested review from liggitt

@humblec humblec Awaiting requested review from humblec

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@dims dims

@xing-yang xing-yang

@pacoxu pacoxu

@SergeyKanzhelev SergeyKanzhelev

@msau42 msau42

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
[sig-release] Bug Triage
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet