update the logic to find missed schedules and most recent schedule

[kmala]

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

This PR fixes the issue of where a cron job controller will try to keep adding cron job to a worker queue immediately if multiple previous executions are skipped because of issues for example previous job is not still not complete.This would both cause the unnecessary work to be done by controller and also quickly fill up the disk even at log level 2. The issue is that logic to find the most recent schedule time is not correct as it assumes that time difference between 2 runs is always constant which is not the case in case of complex schedules like 30 6-16/4 * * 1-5 which means execute mon-fri, starting 6:30 - 16:30 every 4 hours. The logic change for the function was done in #97098 but the issue became prevalent once this function is used for calculating the next schedule duration in #109250. The PR reverts the change to the old way of finding the number of missed schedules as there is no other easy way i could think of.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes cronjob controller handling of failed/stuck  jobs/pods.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Please note that we're already in Test Freeze for the release-1.27 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.27.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Apr 7 20:02:44 UTC 2023.

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @kmala. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kmala]

/sig apps

[dims]

/ok-to-test

[dims]

/assign @soltysh

[kmala]

/test pull-kubernetes-e2e-kind-ipv6

[dims]

/assign @soltysh

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kmala, wasup-yash
Once this PR has been reviewed and has the lgtm label, please ask for approval from soltysh. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/controller/cronjob/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[soltysh]

/label tide/merge-method-squash

[soltysh]

/hold
@kmala have a look at my proposed alternative in #118724

[kmala]

/hold @kmala have a look at my proposed alternative in #118724

Thanks @soltysh It looks good.

[soltysh]

Closing, since #118724 merged
/close

[k8s-ci-robot]

@soltysh: Closed this PR.

In response to this:

Closing, since #118724 merged
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.