Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #117245: Fix TopologyAwareHint not working when zone label is added #117249: Fix a data race in TopologyCache #117268

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Automated cherry pick of #117245: Fix TopologyAwareHint not working when zone label is added #117249: Fix a data race in TopologyCache #117268

merged 2 commits into from
Aug 4, 2023

Commits on Apr 13, 2023

  1. Fix TopologyAwareHint not working when zone label is added after Node… 

    … creation

The topology.kubernetes.io/zone label may be added by could provider
asynchronously after the Node is created. The previous code didn't
update the topology cache after receiving the Node update event, causing
TopologyAwareHint to not work until kube-controller-manager restarts or
other Node events trigger the update.

Signed-off-by: Quan Tian <qtian@vmware.com>
    @tnqn
    tnqn committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    b121565 View commit details
    Browse the repository at this point in the history

  2. Fix a data race in TopologyCache 

    The member variable `cpuRatiosByZone` should be accessed with the lock
acquired as it could be be updated by `SetNodes` concurrently.

Signed-off-by: Quan Tian <qtian@vmware.com>
Co-authored-by: Antonio Ojea <aojea@google.com>
    @tnqn @aojea
    tnqn and aojea committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    12b7029 View commit details
    Browse the repository at this point in the history