Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

call kube::golang::setup_env before setting up worktree, cleanup update-mocks.sh #117526

Merged
merged 4 commits into from
Apr 22, 2023
Merged

call kube::golang::setup_env before setting up worktree, cleanup update-mocks.sh #117526

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
726992f
call kube::golang::setup_env before setting up worktree
BenTheElder Apr 21, 2023
4d736a0
cleanup update-mocks.sh
BenTheElder Apr 21, 2023
63d44fd
retain KUBE_GOPATH on recursive kube::golang
BenTheElder Apr 21, 2023
ed37e69
uncomment exit trap to cleanup tmpdir
BenTheElder Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion hack/verify-internal-modules.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ kube::util::ensure_clean_working_dir
kube::golang::setup_env

_tmpdir="$(kube::realpath "$(mktemp -d -t verify-internal-modules.XXXXXX)")"
#kube::util::trap_add "rm -rf ${_tmpdir}" EXIT
kube::util::trap_add "rm -rf ${_tmpdir:?}" EXIT
thockin marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thockin lost your LGTM pulling this one out

Also adding :? because even though we just set _tmpdir we should encourage the habit of rm -rf ${foo:?} to prevent accidents like rm -rf "${foo:}/" where $foo is unset.


_tmp_gopath="${_tmpdir}/go"
_tmp_kuberoot="${_tmp_gopath}/src/k8s.io/kubernetes"
Expand Down