Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: use gomega.Expect instead of framework.ExpectEqual in kubectl #117963

Merged
merged 1 commit into from
May 22, 2023
Merged

e2e: use gomega.Expect instead of framework.ExpectEqual in kubectl #117963

merged 1 commit into from
May 22, 2023

Conversation

humblec
Copy link
Contributor

@humblec humblec commented May 12, 2023 •
edited

/kind cleanup

Below framework funcs are deprecated and this PR update the same with gomega constraints

  • framework.ExpectEqual
  • framework.ExpectNotEqual
  • framework.ExpectError
NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 12, 2023
@k8s-ci-robot k8s-ci-robot added area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 12, 2023
@humblec humblec changed the title e2e: use gomega.Expect instead of framework.ExpectEqual in dra and kubectl [WIP] e2e: use gomega.Expect instead of framework.ExpectEqual in dra and kubectl May 12, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2023
@humblec humblec changed the title [WIP] e2e: use gomega.Expect instead of framework.ExpectEqual in dra and kubectl e2e: use gomega.Expect instead of framework.ExpectEqual in dra and kubectl May 12, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2023
@humblec
Copy link
Contributor Author

humblec commented May 12, 2023

/test pull-kubernetes-kind-dra

@humblec
Copy link
Contributor Author

humblec commented May 12, 2023

/test pull-kubernetes-integration

@humblec
Copy link
Contributor Author

humblec commented May 12, 2023

/test pull-kubernetes-kind-dra

@humblec humblec changed the title e2e: use gomega.Expect instead of framework.ExpectEqual in dra and kubectl e2e: use gomega.Expect instead of framework.ExpectEqual in kubectl May 12, 2023
@humblec
Copy link
Contributor Author

humblec commented May 12, 2023

/assign @brianpursley

@bart0sh bart0sh added this to Triage in SIG Node PR Triage May 14, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 15, 2023
@humblec humblec requested a review from brianpursley May 15, 2023 05:07
@bart0sh
Copy link
Contributor

bart0sh commented May 15, 2023

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 15, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage May 15, 2023
brianpursley
brianpursley suggested changes May 16, 2023
View reviewed changes
Copy link
Member

@brianpursley brianpursley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you squash your commits?

@humblec
e2e: use gomega.Expect instead of deprecated framework.Expect*
51d79c4 
replace below functions:

 framework.ExpectEqual
 framework.ExpectNotEqual
 framework.ExpectError

Ref#115961

Signed-off-by: Humble Chirammal <humble.devassy@gmail.com>
@humblec humblec requested a review from brianpursley May 17, 2023 02:28
@humblec
Copy link
Contributor Author

humblec commented May 17, 2023

Looks good. Can you squash your commits?

@brianpursley I have squashed the commits.. ptal . thanks!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 17, 2023 •
edited

@humblec: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-kind-dra 8de1f2350aa6081a160ef5ac004ca87d4ce5991e link false /test pull-kubernetes-kind-dra

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@humblec
Copy link
Contributor Author

humblec commented May 17, 2023

/test pull-kubernetes-e2e-gce

@SergeyKanzhelev
Copy link
Member

/remove-sig node
/sig cli

@k8s-ci-robot k8s-ci-robot removed the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 17, 2023
brianpursley
brianpursley approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@brianpursley brianpursley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @humblec

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d09cc36052436ee40e01de76f80fed067861757

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianpursley, humblec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit b5ce9a5 into kubernetes:master May 22, 2023
13 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done May 22, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley brianpursley approved these changes

@klueska klueska Awaiting requested review from klueska

Assignees

@brianpursley brianpursley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@humblec @bart0sh @k8s-ci-robot @SergeyKanzhelev @brianpursley