fix Cronjob status.lastSuccessfulTime not populated by a manually triggered job

[carlory]

What type of PR is this?

/kind bug

What this PR does / why we need it:

// cronjob status when job fail 

(⎈|kind-kind:default)➜  ~ kubectl get cronjob -o jsonpath='{.items[*].status}' | jq
{
  "lastScheduleTime": "2023-06-07T15:27:00Z",
  "lastSuccessfulTime": "2023-06-07T15:25:07Z"
}

// cronjob status when a manually triggered job complete before next scheduled time is reach

(⎈|kind-kind:default)➜  ~ kubectl get cronjob -o jsonpath='{.items[*].status}' | jq
{
  "lastScheduleTime": "2023-06-07T15:27:00Z",
  "lastSuccessfulTime": "2023-06-07T15:27:39Z"
}

Which issue(s) this PR fixes:

Fixes #118276

Special notes for your reviewer:

https://github.com/kubernetes/kubernetes/blob/8d78d5e19cc80c860faa7cb32e31e9cb0a31e9e5/pkg/controller/cronjob/cronjob_controllerv2.go#L252-L270

Does this PR introduce a user-facing change?

Fix Cronjob status.lastSuccessfulTime not populated by a manually triggered job

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[carlory]

/assign @apelisse

[apelisse]

I'm not super familiar with this code. Why does this work?

[carlory]

@apelisse

The cronjob controller watch cronjob and job events. When a job is created, the registered eventhander for job will check if the job has a ControlRef and then add the corresponding cronjob into the workqueue. However, when kubectl create a job from a cronjob, it sets a ownReference with the controller field unset so the job's event won't be handled by the cronjob controller. This pr set the controller field to true. when reconcile a conjob, the controller will list jobs and filters them by the controller ref.

FYI:

1. https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/cronjob/cronjob_controllerv2.go#L432
2. https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/cronjob/utils.go#L188

[apelisse]

/assign @soltysh

[soltysh]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: e4259ed084d7e6c9ab3aac2fb240f6affe1214e4

[soltysh]

/triage accepted
/priority backlog

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, soltysh, Tusenka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/kubectl/OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment