Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schedule logic to properly calculate missed schedules #118724

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Update schedule logic to properly calculate missed schedules #118724

merged 1 commit into from
Jun 27, 2023

Commits on Jun 27, 2023

  1. Update schedule logic to properly calculate missed schedules 

    Before this change we've assumed a constant time between schedule runs,
which is not true for cases like "30 6-16/4 * * 1-5".
The fix is to calculate the potential next run using the fixed schedule
as the baseline, and then go back one schedule back and allow the cron
library to calculate the correct time.

This approach saves us from iterating multiple times between last
schedule time and now, if the cronjob for any reason wasn't running for
significant amount of time.
    @soltysh
    soltysh committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    af1c9e4 View commit details
    Browse the repository at this point in the history