Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dra: kubelet must skip NodePrepareResource if not used by any container #118786

Merged
merged 3 commits into from Jun 27, 2023

Commits on Jun 21, 2023

  1. e2e dra: add "kubelet must skip NodePrepareResource if not used by an…

    …y container"
    
    If (for whatever reason) no container uses a claim, then there's no need to
    prepare it.
    pohly committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    ec70b2e View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. kubelet dra: fix checking of second pod which uses a claim

    When a second pod wanted to use a claim, the obligatory sanity check whether
    the pod is really allowed to use the claim ("reserved for") was skipped.
    pohly committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    874daa8 View commit details
    Browse the repository at this point in the history
  2. kubelet dra: restore skipping of unused resource claims

    1aeec10 removed iterating over containers in favor of iterating over pod
    claims. This had the unintended consequence that NodePrepareResource gets
    called unnecessarily when no container needs the claim. The more natural
    behavior is to skip unused resources. This enables (theoretic, at this time)
    use cases where some DRA driver relies on the controller part to influence
    scheduling, but then doesn't use CDI with containers.
    pohly committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    bde66bf View commit details
    Browse the repository at this point in the history