New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Make CA valid 1 hour in the past" #118903
Revert "Make CA valid 1 hour in the past" #118903
Conversation
Hi @champtar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm We will allow this by adding an option on the config struct without changing default behavior and that can be backported. |
LGTM label has been added. Git tree hash: 28505ba0bdc881e3c53a2c2933bdbd8c42434928
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: champtar, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@deads2k need ok to test |
/ok-to-test |
/triage accepted |
Reverts #118631
As discussed on slack (https://kubernetes.slack.com/archives/C0EG7JC6T/p1687815949656259), we will make a new version that doesn't change the default behavior