Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #117865: Parallel StatefulSet pod create & delete #119096

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Automated cherry pick of #117865: Parallel StatefulSet pod create & delete #119096

merged 3 commits into from
Jul 12, 2023

Conversation

aleksandra-malinowska
Copy link
Contributor

@aleksandra-malinowska aleksandra-malinowska commented Jul 5, 2023 •
edited
Loading

Cherry pick of #117865 on release-1.27.

#117865: Refactor StatefulSet controller update logic

For details on the cherry pick process, see the cherry pick requests page.

Fixed a performance issue where pods weren't created/deleted in parallel for a StatefulSet with podManagementPolicy: Parallel.

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jul 5, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 5, 2023
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 5, 2023
@aleksandra-malinowska
Copy link
Contributor Author

This is stuck on #119016.

@aleksandra-malinowska aleksandra-malinowska force-pushed the automated-cherry-pick-of-#117865-upstream-release-1.27 branch from cc33d13 to 28c79be Compare July 10, 2023 10:31
@aleksandra-malinowska
Copy link
Contributor Author

/retest

@alculquicondor
Copy link
Member

/assign @soltysh

@aleksandra-malinowska
Copy link
Contributor Author

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 11, 2023
soltysh
soltysh approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 05796bae45f866b89b4270603428c3483ef236be

@soltysh
Copy link
Contributor

soltysh commented Jul 11, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleksandra-malinowska, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 11, 2023
@aleksandra-malinowska aleksandra-malinowska changed the title Automated cherry pick of #117865: Refactor StatefulSet controller update logic Automated cherry pick of #117865: Parallel StatefulSet pod create & delete Jul 11, 2023
Verolop
Verolop reviewed Jul 12, 2023
View reviewed changes
Copy link

@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 12, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 12, 2023
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5ee5d73 into kubernetes:release-1.27 Jul 12, 2023
14 checks passed
nishokvg
nishokvg reviewed Jul 16, 2023
View reviewed changes
Copy link

@nishokvg nishokvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkatabat vkatabat mentioned this pull request Aug 17, 2023
Closed
@liggitt liggitt mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Verolop Verolop Verolop left review comments

@nishokvg nishokvg nishokvg left review comments

@soltysh soltysh soltysh approved these changes

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@soltysh soltysh

@Verolop Verolop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aleksandra-malinowska @alculquicondor @k8s-ci-robot @soltysh @k8s-triage-robot @Verolop @nishokvg