kubeadm: Make dry-run is configurable in initConfiguration and joinConfiguration

[chendave]

The dry-run flag was able to use with the config file, since it was not configurable in the config file.

Make it configurable in v1beta4, so that eventually, kubeadm could deprecate the flag and suggest to use the config file instead.

/kind feature

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of: #kubernetes/kubeadm#2890
Part of: #kubernetes/kubeadm#2902

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/hold

After I finishing this, I realized this should wait until the v1beta4 is enabled across the code base, so we can

• Add the testcase to coverage this new field in v1beta4
• Make the initData.cfg.DryRun to be consistent with initData.dryRun

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[neolit123]

/approve

[neolit123]

we should mention this and the join config addition in the v1beta4 doc.go

[chendave]

we should mention this and the join config addition in the v1beta4 doc.go

yes, I fogot to include the change in the doc.go.

Let's hold this until v1beta4 is enabled, so that I can add testcases for this.

[neolit123]

/lgtm
/hold

drop the hold when needed, please.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: fb9dc78e5f3bf2bc7cb94018082918bb682be9d8

[neolit123]

actually...why not add the change in joinconfiguration too here? no need for separate PR. separate commit seems ok to me, but it's your preference.

[chendave]

actually...why not add the change in joinconfiguration too here? no need for separate PR. separate commit seems ok to me, but it's your preference.

Done
This is actually a API change, as we are still on v1beta3 now, let's defer this to 1.29 when v1beta4 is used.

[chendave]

/retitle kubeadm: Make dry-run is configurable in initConfiguration and joinConfiguration

[neolit123]

/lgtm
/approve
/hold

thanks, if there are no other comments please drop the hold.

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 28ff98927db69f227f0194947287e2d681163203

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chendave, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/kubeadm/OWNERS [neolit123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chendave]

/unhold