Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement SchedulerQueueingHints feature gate #119328

Merged

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Jul 14, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Ref: #118438 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added a new feature gate, `SchedulerQueueingHints` (enabled by default).
The new feature gate activates a framework for fine-grained filtering of events related to scheduler plugins.
In this release, no default scheduling plugins make use of the hinting framework, so you should not expect any behavior changes.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 14, 2023
@sanposhiho
Copy link
Member Author

/triage accepted
/cc @alculquicondor @Huang-Wei @ahg-g
/sig scheduling

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 14, 2023
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/assign @ahg-g

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 90c8e7f74986e83b5e8e2b0f73a55da5234d2c91

@ahg-g
Copy link
Member

ahg-g commented Jul 14, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, alculquicondor, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1b7fffa into kubernetes:master Jul 14, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 14, 2023
@tengqm
Copy link
Contributor

tengqm commented Jul 16, 2023

Is there a docs proposal to k8s.io/website?

The text in the commit message, especially the "user-facing" change is not easy to parse.
The question from a user's perspective is ... Why this new gate? Do I have to know which
functions are called by the scheduler? What will happen to my workload if I enable/disable
this gate?

@alculquicondor
Copy link
Member

It's more of a release note to developers of scheduler plugins.

Maybe we should just remove the release note here, as the public for them is end users?

@alculquicondor
Copy link
Member

OTOH, the feature gate is user facing. Let me try:

/release-note-edit

The feature gate SchedulerQueueingHints (enabled by default) provides a framework for fine-grained filtering of events for scheduler plugins. In this release, no default scheduling plugins make use of the hinting framework, so you should not expect any behavior changes.

@sanposhiho
Copy link
Member Author

@alculquicondor Thanks for handling 🙏

@sftim
Copy link
Contributor

sftim commented Jul 19, 2023

Changelog suggestion

Added a new feature gate, `SchedulerQueueingHints` (enabled by default)
The new feature gate activates a framework for fine-grained filtering of events that related to
scheduler plugins.
In this release, no default scheduling plugins make use of the hinting framework, so you should not
expect any behavior changes.

@alculquicondor
Copy link
Member

/release-note-edit

Added a new feature gate, `SchedulerQueueingHints` (enabled by default).
The new feature gate activates a framework for fine-grained filtering of events related to scheduler plugins.
In this release, no default scheduling plugins make use of the hinting framework, so you should not expect any behavior changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants