Increase timeout for DRA kubelet plugin client #119414
Conversation
The 10 second timeout was too low. Given that the retry loop for the kubelet itself is 90s, increasing the timeout to half of this seems reasonable. Ideally we would pull in the variable that sets the retry timeout to 90s and then just set our local timeout to half of that. Unfortunately, this is not exported, so we settle (for now with just explicitly setting it to 45s. Signed-off-by: Kevin Klues <kklues@nvidia.com>
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-triage
|
/sig node |
k8s-ci-robot
added
release-note-none
| @@ -34,7 +34,7 @@ import ( | |||
| drapb "k8s.io/kubelet/pkg/apis/dra/v1alpha3" | |||
| ) | |||
|
|
|||
| const PluginClientTimeout = 10 * time.Second | |||
| const PluginClientTimeout = 45 * time.Second | |||
There was a problem hiding this comment.
the PrepareResources iterates over the plugins and each will now has increased timeout. Is there needed some parallelization?
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 12afc3f846ec296fb65d7b07ba5022c3347c4141
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: klueska, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The 10 second timeout was too low. Given that the retry loop for the kubelet itself is 90s, increasing the timeout to half of this seems reasonable. Ideally we would pull in the variable that sets the retry timeout to 90s and then just set our local timeout to half of that. Unfortunately, this is not exported, so we settle (for now) with just explicitly setting it to 45s.