Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate APIListChunking to GA #119503

Merged
merged 3 commits into from Aug 23, 2023
Merged

Graduate APIListChunking to GA #119503

merged 3 commits into from Aug 23, 2023

Conversation

wojtek-t
Copy link
Member

Ref kubernetes/enhancements#365
Ref #108003

Graduation API List chunking (aka pagination) feature to stable

/sig api-machinery
/kind feature
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 21, 2023
@wojtek-t
Copy link
Member Author

/hold

Wait for kubernetes/enhancements#3274 to be approved first.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/apiserver area/provider/gcp Issues or PRs related to gcp provider area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 21, 2023
@wojtek-t wojtek-t force-pushed the pagination_ga branch 3 times, most recently from c231a25 to cdce100 Compare July 21, 2023 12:01
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 21, 2023
@wojtek-t
Copy link
Member Author

/retest

1 similar comment
@wojtek-t
Copy link
Member Author

/retest

@alexzielenski
Copy link
Contributor

/cc @deads2k @jpbetz
/triage accepted

@k8s-ci-robot k8s-ci-robot requested a review from jpbetz July 25, 2023 20:02
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 25, 2023
@wojtek-t
Copy link
Member Author

wojtek-t commented Aug 3, 2023

/assign @jpbetz @deads2k

With KEP PR already merged:
/hold cancel

/retest

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@jpbetz
Copy link
Contributor

jpbetz commented Aug 3, 2023

The only thing I wanted to point out before LGTM is that the conformance test randomizes the "limit" used to paginate. Are we OK with having a non-deterministic conformance test like this? When run repeatedly it will find various edge cases, but it won't find them on each run.

@wojtek-t
Copy link
Member Author

The only thing I wanted to point out before LGTM is that the conformance test randomizes the "limit" used to paginate. Are we OK with having a non-deterministic conformance test like this? When run repeatedly it will find various edge cases, but it won't find them on each run.

It's a fair question - I think we should avoid non-determinism. I just changed the test to be deterministic now. PTAL
@jpbetz

@jpbetz
Copy link
Contributor

jpbetz commented Aug 23, 2023

/lgtm
/approve

Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b8813e518ddbef102262b28d7a52f094bebc4dc1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2e6eafc into kubernetes:master Aug 23, 2023
12 of 14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 23, 2023
@sftim
Copy link
Contributor

sftim commented Aug 29, 2023

Please update the docs around this for v1.29

@wojtek-t
Copy link
Member Author

Please update the docs around this for v1.29

Yup - on my list. Just we have quite a bit of time still for it.

@wojtek-t
Copy link
Member Author

Opened kubernetes/website#42800

@Riaankl Riaankl mentioned this pull request Sep 10, 2023
Closed
This was referenced Oct 20, 2023
Merged
Closed
@wojtek-t wojtek-t mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@deads2k deads2k Awaiting requested review from deads2k

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@jpbetz jpbetz

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wojtek-t @alexzielenski @jpbetz @k8s-ci-robot @sftim @deads2k