-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run all PreFilter when the preemption will happen later in the same scheduling cycle #119779
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -139,6 +139,7 @@ type ScheduleResult struct { | |||
SuggestedHost string | ||||
// The number of nodes the scheduler evaluated the pod against in the filtering | ||||
// phase and beyond. | ||||
// Note that it contains the number of nodes that filtered out by PreFilterResult. | ||||
EvaluatedNodes int | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. EvaluatedNodes is only used in logging, not being used at anywhere else like any functionalities or metrics. So, this change doesn't cause anything bad. kubernetes/pkg/scheduler/schedule_one.go Line 304 in 6cf7709
(It leads us to another question; whether this EvaluatedNodes is worthwhile to keep or not in the first place though)
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've find this information useful when debugging in the past. |
||||
// The number of nodes out of the evaluated ones that fit the pod. | ||||
FeasibleNodes int | ||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this number shouldn't have changed?
Although it's only useful for debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be changed.
Please refer to the change in pkg/scheduler/scheduler.go in this PR: After this PR, EvaluatedNodes contains the number of nodes that filtered out by PreFilterResult.
https://github.com/kubernetes/kubernetes/pull/119779/files#r1439161728
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I understand that it's not a bug. However, it was useful to have the value 1 to know that only one node passed PreFilter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Then, we have to change how to calculate
EvaluatedNodes
.https://github.com/sanposhiho/kubernetes/blob/master/pkg/scheduler/schedule_one.go#L435
Created #124705