Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual cherry pick of #119800: Fixes CEL estimated cost to propagate result sizes correctly #119809

Merged
merged 4 commits into from Sep 7, 2023
Merged

Manual cherry pick of #119800: Fixes CEL estimated cost to propagate result sizes correctly #119809

merged 4 commits into from Sep 7, 2023

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Aug 7, 2023 •
edited

Cherry pick of #119800 on release-1.27.

#119800: Fixes CEL estimated cost to propagate result sizes correctly

The version bump was performed manually since we depend on a different CEL version in 1.27 than on 1.28 and master.

For details on the cherry pick process, see the cherry pick requests page.

Fixed a bug where CEL expressions in CRD validation rules would incorrectly compute a high estimated cost for functions that return strings, lists or maps.
The incorrect cost was evident when the result of a function was used in subsequent operations.

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Aug 7, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 7, 2023
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, cheftako and a team August 7, 2023 22:34
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 7, 2023
@jpbetz jpbetz changed the title Manual cherry pick of #119800: Bump cel-go to v0.16.1 (CEL estimated cost fix) #119807 Manual cherry pick of #119800: Fixes CEL estimated cost to propagate result sizes correctly Aug 7, 2023
@jpbetz
Copy link
Contributor Author

jpbetz commented Aug 7, 2023

/priority important-soon
/sig api-machinery

/hold
Until #119800 merges

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 7, 2023
@jpbetz
Copy link
Contributor Author

jpbetz commented Aug 7, 2023

/retest

@jpbetz
Copy link
Contributor Author

jpbetz commented Aug 16, 2023

/hold cancel

This is ready for backport.

/assign @cici37

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2023
@liggitt
Copy link
Member

liggitt commented Aug 17, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 163efa8beedd4bf1abba0b7aef1a7ed8ef72eca8

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023
@liggitt
Copy link
Member

liggitt commented Aug 17, 2023

/hold until #119800 (comment) is understood/fixed

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023
jpbetz and others added 2 commits August 22, 2023 19:34
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 22, 2023
@jpbetz
Copy link
Contributor Author

jpbetz commented Aug 23, 2023

/hold cancel
This is updated with fixes from #120097 and ready to merge.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2023
@liggitt
Copy link
Member

liggitt commented Aug 23, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0998c8bfa10f7b1cecd2a38d513d98840373a035

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Verolop
Verolop reviewed Sep 6, 2023
View reviewed changes
Copy link

@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 6, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 6, 2023
@pacoxu
Copy link
Member

pacoxu commented Sep 7, 2023

/retest-required

@pacoxu
Copy link
Member

pacoxu commented Sep 7, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit f473f0d into kubernetes:release-1.27 Sep 7, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Verolop Verolop Verolop left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

@cici37 cici37 Awaiting requested review from cici37

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@Verolop Verolop

@cici37 cici37

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jpbetz @alexzielenski @liggitt @k8s-ci-robot @pacoxu @Verolop @cici37