[release-1.26] releng/go: Bump images, versions and deps to use Go 1.20.7 #119830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
sig/release
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-priority
jeremyrickard
force-pushed
the
1207-1.26
branch
from
41a843c
to
f32d801
Compare
31 tasks
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: dc208d9e653c6c46374eb80013532cc3658ede59
|
jeremyrickard
force-pushed
the
1207-1.26
branch
from
f32d801
to
bd2623e
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 678bacf2a8922a4b027a49ba5c9664401ac5e386
|
liggitt
reviewed
Aug 8, 2023
jeremyrickard
force-pushed
the
1207-1.26
branch
from
bd2623e
to
f54005e
Compare
k8s-ci-robot
removed
the
lgtm
|
/retest |
liggitt
reviewed
Aug 8, 2023
hack/lib/protoc.sh
Outdated
| echo | ||
| echo "WARNING: Protobuf changes are not being validated" | ||
| exit 1 | ||
| if [[ -z "$(which protoc)" || "$(protoc --version)" != "libprotoc ${PROTOC_VERSION}"* ]]; then |
There was a problem hiding this comment.
I'd suggest this diff instead:
- if [[ -z "$(which protoc)" || "$(protoc --version)" != "libprotoc 3."* ]]; then
- echo "Generating protobuf requires protoc 3.0.0-beta1 or newer. Please download and"
+ if [[ -z "$(which protoc)" || "$(protoc --version)" != "libprotoc 23.4"* ]]; then
+ echo "Generating protobuf requires protoc 23.4 or newer. Please download and"install-protoc.sh doesn't exist and we're not using PROTOC_VERSION elsewhere
| fi | ||
| # Checks that the current protoc version matches the required version and | ||
| # exit 1 if it's not the case | ||
| function kube::protoc::check_protoc() { |
There was a problem hiding this comment.
copy the same diff instead of declaring a function here (which isn't invoked and isn't checking anything)
- if [[ -z "$(which protoc)" || "$(protoc --version)" != "libprotoc 3."* ]]; then
- echo "Generating protobuf requires protoc 3.0.0-beta1 or newer. Please download and"
+ if [[ -z "$(which protoc)" || "$(protoc --version)" != "libprotoc 23.4"* ]]; then
+ echo "Generating protobuf requires protoc 23.4 or newer. Please download and"| echo "WARNING: Protobuf changes are not being validated" | ||
| exit 1 | ||
| fi | ||
| # Checks that the current protoc version matches the required version and |
There was a problem hiding this comment.
same diff here instead of declaring a function
…20.7 and update protoc Signed-off-by: Jeremy Rickard <jeremyrrickard@gmail.com>
jeremyrickard
force-pushed
the
1207-1.26
branch
from
f54005e
to
e791a3f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0624f9d047e201f8dc2b5ee26c85386abb7cfb2f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeremyrickard, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
jeremyrickard
added
the
cherry-pick-approved
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
xref kubernetes/release#3181
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @saschagrunert @cpanato
cc @kubernetes/release-engineering