[release-1.24] releng/go: Bump images, versions and deps to use Go 1.20.7 and newer protoc #119837
Conversation
k8s-ci-robot
added
do-not-merge/cherry-pick-not-approved
k8s-ci-robot
added
size/M
k8s-ci-robot
added
cncf-cla: yes
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-priority
k8s-ci-robot
added
area/test
sig/release
jeremyrickard
force-pushed
the
1207-1.24
branch
from
34f186b
to
1b7a31b
Compare
…20.7 Signed-off-by: Jeremy Rickard <jeremyrrickard@gmail.com>
jeremyrickard
force-pushed
the
1207-1.24
branch
from
1b7a31b
to
90c2586
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 64e5acd2d446ce90d9fe82f9373ea7031a909e1c
|
k8s-ci-robot
added
the
approved
|
/test pull-kubernetes-verify |
|
1.24 is done, right? (this PR isn't to merge) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c05c22d1039f3196b905e9c18c682ca174f615d2
|
|
/retest the vet error is weird… nothing in vet changed between 1.20.6 and 1.20.7 |
|
Might need to pick #111846 but I have no idea why CI chose now to complain about this on release-1.24 |
Fixes instances of kubernetes#98213 (to ultimately complete kubernetes#98213 linting is required). This commit fixes a few instances of a common mistake done when writing parallel subtests or Ginkgo tests (basically any test in which the test closure is dynamically created in a loop and the loop doesn't wait for the test closure to complete). I'm developing a very specific linter that detects this king of mistake and these are the only violations of it it found in this repo (it's not airtight so there may be more). In the case of Ginkgo tests, without this fix, only the last entry in the loop iteratee is actually tested. In the case of Parallel tests I think it's the same problem but maybe a bit different, iiuc it depends on the execution speed. Waiting for the CI to confirm the tests are still passing, even after this fix - since it's likely it's the first time those test cases are executed - they may be buggy or testing code that is buggy. Another instance of this is in `test/e2e/storage/csi_mock_volume.go` and is still failing so it has been left out of this commit and will be addressed in a separate one
k8s-ci-robot
added
sig/apps
OK, to test this out I cherry picked that into this PR. If it's successful I can remove it and do a separate cherry pick PR and rebase on the branch after that goes in. |
if it's successful I don't mind merging it in a single PR |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeremyrickard, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 38ef5e3bdc961ce206941920fd5be3d00190ab1c
|
|
/retest |
1 similar comment
|
/retest |
Verolop
added
the
cherry-pick-approved
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
xref kubernetes/release#3181
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @saschagrunert @cpanato
cc @kubernetes/release-engineering