Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #118895 from RyanAoh/kep-1860" #119876

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Revert "Merge pull request #118895 from RyanAoh/kep-1860" #119876

merged 1 commit into from
Aug 10, 2023

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Aug 9, 2023

This reverts commit 890a6c8, reversing changes made to 4f60a8d.

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This reverts #118895 which accidently merged for 1.28.
Slack discussion - https://kubernetes.slack.com/archives/CJH2GBF7Y/p1691553548475109

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig release network
/cc @jeremyrickard @gracenng @leonardpahlke

@marosset
Revert "Merge pull request kubernetes#118895 from RyanAoh/kep-1860"
0d90d1f 
This reverts commit 890a6c8, reversing
changes made to 4f60a8d.
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 9, 2023
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Aug 9, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.28 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.28.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 22:34:30 UTC 2023.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/cloudprovider area/code-generation area/ipvs area/kube-proxy area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 9, 2023
@marosset
Copy link
Contributor Author

marosset commented Aug 9, 2023

/milestone v1.28

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Aug 9, 2023
@marosset
Copy link
Contributor Author

marosset commented Aug 9, 2023

/cc @RyanAoh

@dims
Copy link
Member

dims commented Aug 9, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 66fd8a51120d24c2811cd8f9982691ae247f656b

@aojea
Copy link
Member

aojea commented Aug 9, 2023

/lgtm

for sig network

@jpbetz
Copy link
Contributor

jpbetz commented Aug 9, 2023

/approve
for sig api-machinery

@marosset
Copy link
Contributor Author

/test pull-kubernetes-unit

@liggitt
Copy link
Member

liggitt commented Aug 10, 2023

/approve
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jpbetz, liggitt, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit e6218f3 into kubernetes:master Aug 10, 2023
15 checks passed
This was referenced Aug 14, 2023
Merged
Merged
@alexzielenski
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gracenng gracenng Awaiting requested review from gracenng

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@leonardpahlke leonardpahlke Awaiting requested review from leonardpahlke

@RyanAoh RyanAoh Awaiting requested review from RyanAoh

Assignees

@dims dims

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/code-generation area/ipvs area/kube-proxy area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@marosset @k8s-ci-robot @dims @aojea @jpbetz @liggitt @alexzielenski