Add a kubectl rollout undo e2e test #119915

AxeZhan · 2023-08-12T12:54:16Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Currently we don't have test for kubectl rollout undo,some code changes may affect this behavior(take #116759 as an example). We should add some tests to always ensure kubectl rollout undo is not broken. This pr adds a simple e2e test for it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2023-08-12T12:54:20Z

Please note that we're already in Test Freeze for the release-1.28 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.28.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sat Aug 12 10:37:24 UTC 2023.

k8s-ci-robot · 2023-08-12T12:54:24Z

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

AxeZhan · 2023-08-12T16:03:45Z

/cc @atiratree

test/e2e/kubectl/kubectl.go

test/e2e/testing-manifests/kubectl/labeld-deployment.yaml.in

test/e2e/kubectl/kubectl.go

atiratree · 2023-08-24T11:01:49Z

thx for the update
/lgtm

aojea · 2023-08-24T15:29:13Z

/hold cancel

Thanks

AxeZhan · 2023-08-24T15:46:18Z

@aojea Updated, PTAL

soltysh

A few minor nits, pls ping me when you get them updated.

test/e2e/kubectl/kubectl.go

AxeZhan · 2023-08-25T12:29:03Z

@soltysh

test/e2e/kubectl/rollout.go

soltysh · 2023-08-25T13:34:18Z

test/e2e/kubectl/rollout.go

+	})
+
+	ginkgo.Describe("undo", func() {
+		deploymentYaml := commonutils.SubstituteImageName(string(readTestFileOrDie(labeledDeploymentFilename)))


I still don't understand why you can't use the existing files, rather than creating yet another one?

We want to test that the deployment has only the original set of labels and annotations? To confirm this, it might be good to add some to the original yaml. And I'm not sure whether changing the existing files will break sth, so I created a new one. If it's ok I can add some labels to the existing file and then use it :)

kindly ping @soltysh :)

Right, but you only inject new envs, thus re-using all the labels and annotations just to ensure they don't change after rollback, so what's stopping you from using an existing deployment file?

Well, it's not that complicated. I'm just not sure if it's ok to modify an existing file. Updated to use httpd yaml now. I'll squash if the rest is ok.

ping @soltysh

test/e2e/kubectl/rollout.go

AxeZhan · 2023-09-19T02:23:56Z

@soltysh

AxeZhan · 2023-10-08T03:27:07Z

ping @soltysh

pacoxu · 2023-10-08T07:29:28Z

/approve

k8s-ci-robot · 2023-10-08T07:29:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AxeZhan, dims, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [dims]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dims · 2023-10-08T14:58:59Z

/lgtm

k8s-ci-robot · 2023-10-08T14:59:05Z

LGTM label has been added.

Git tree hash: 7c5313f9ceee271159240e6e76cedc04bd7d6cd1

AxeZhan · 2023-10-09T01:47:41Z

/retest

pacoxu · 2023-10-09T02:32:10Z

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119915/pull-kubernetes-e2e-gce/1711034185398882304 failed for a recent top flake #121013 that was fixed early today.
To avoid it, you may retest or rebase with the latest master branch.

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 12, 2023

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2023

k8s-ci-robot requested review from seans3 and soltysh August 12, 2023 12:54

k8s-ci-robot added area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 12, 2023

k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 12, 2023

AxeZhan force-pushed the rollout_e2e branch 4 times, most recently from 9f0eaf6 to 2c55f16 Compare August 12, 2023 14:32

k8s-ci-robot requested a review from atiratree August 12, 2023 16:03

AxeZhan mentioned this pull request Aug 12, 2023

add kubernetes.io prefix to pod-template-hash label #116759

Closed

atiratree reviewed Aug 21, 2023

View reviewed changes

AxeZhan force-pushed the rollout_e2e branch from 2c55f16 to 7ab2570 Compare August 22, 2023 08:32

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 22, 2023

atiratree reviewed Aug 22, 2023

View reviewed changes

AxeZhan force-pushed the rollout_e2e branch from fdbe9b1 to e7baac9 Compare August 22, 2023 14:40

k8s-ci-robot assigned atiratree Aug 24, 2023

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2023

AxeZhan force-pushed the rollout_e2e branch from 46d4a54 to 64c056a Compare August 24, 2023 14:21

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2023

k8s-ci-robot requested review from atiratree and dims August 24, 2023 14:21

AxeZhan force-pushed the rollout_e2e branch from 64c056a to 08c2979 Compare August 24, 2023 14:44

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2023

soltysh reviewed Aug 25, 2023

View reviewed changes

test/e2e/kubectl/kubectl.go Outdated Show resolved Hide resolved

test/e2e/kubectl/kubectl.go Outdated Show resolved Hide resolved

test/e2e/kubectl/kubectl.go Outdated Show resolved Hide resolved

add kubectl rollout e2e test

dec1c36

AxeZhan force-pushed the rollout_e2e branch from 08c2979 to dec1c36 Compare August 25, 2023 12:25

soltysh reviewed Aug 25, 2023

View reviewed changes

remove fake deployment

ff10df1

AxeZhan requested a review from soltysh August 29, 2023 02:00

remove labeld-deployment.yaml

ff3cb43

atiratree reviewed Sep 5, 2023

View reviewed changes

test/e2e/kubectl/rollout.go Outdated Show resolved Hide resolved

check labels/annotations in the beginning

059e835

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2023

k8s-ci-robot merged commit cdc026f into kubernetes:master Oct 9, 2023
15 checks passed

k8s-ci-robot added this to the v1.29 milestone Oct 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a kubectl rollout undo e2e test #119915

Add a kubectl rollout undo e2e test #119915

AxeZhan commented Aug 12, 2023

k8s-ci-robot commented Aug 12, 2023

k8s-ci-robot commented Aug 12, 2023

AxeZhan commented Aug 12, 2023

atiratree commented Aug 24, 2023

aojea commented Aug 24, 2023

AxeZhan commented Aug 24, 2023

soltysh left a comment

AxeZhan commented Aug 25, 2023

soltysh Aug 25, 2023

AxeZhan Aug 25, 2023

AxeZhan Aug 25, 2023

soltysh Sep 4, 2023

AxeZhan Sep 4, 2023

AxeZhan Sep 4, 2023

AxeZhan commented Sep 19, 2023

AxeZhan commented Oct 8, 2023

pacoxu commented Oct 8, 2023

k8s-ci-robot commented Oct 8, 2023

dims commented Oct 8, 2023

k8s-ci-robot commented Oct 8, 2023

AxeZhan commented Oct 9, 2023

pacoxu commented Oct 9, 2023 •

edited

Add a kubectl rollout undo e2e test #119915

Add a kubectl rollout undo e2e test #119915

Conversation

AxeZhan commented Aug 12, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Aug 12, 2023

k8s-ci-robot commented Aug 12, 2023

AxeZhan commented Aug 12, 2023

atiratree commented Aug 24, 2023

aojea commented Aug 24, 2023

AxeZhan commented Aug 24, 2023

soltysh left a comment

Choose a reason for hiding this comment

AxeZhan commented Aug 25, 2023

soltysh Aug 25, 2023

Choose a reason for hiding this comment

AxeZhan Aug 25, 2023

Choose a reason for hiding this comment

AxeZhan Aug 25, 2023

Choose a reason for hiding this comment

soltysh Sep 4, 2023

Choose a reason for hiding this comment

AxeZhan Sep 4, 2023

Choose a reason for hiding this comment

AxeZhan Sep 4, 2023

Choose a reason for hiding this comment

AxeZhan commented Sep 19, 2023

AxeZhan commented Oct 8, 2023

pacoxu commented Oct 8, 2023

k8s-ci-robot commented Oct 8, 2023

dims commented Oct 8, 2023

k8s-ci-robot commented Oct 8, 2023

AxeZhan commented Oct 9, 2023

pacoxu commented Oct 9, 2023 • edited

pacoxu commented Oct 9, 2023 •

edited