Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add exemplar support for counters #119949

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

metrics: add exemplar support for counters #119949

wants to merge 1 commit into from
+140 −35

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Aug 15, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

adds exemplar support for counters

  • utilizes Prometheus' underlying exemplar machinery
  • introduces contextual counters (which were a no-op till now)
  • adds testcases

Which issue(s) this PR fixes:

addresses (a part of): #119697

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

(exemplar operations are done implicitly in this implementation)

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 15, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.28 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.28.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Aug 15 10:37:05 UTC 2023.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Aug 15, 2023
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 15, 2023
@rexagod rexagod force-pushed the 119697-1 branch 2 times, most recently from be65735 to 3220f9c Compare August 15, 2023 12:11
@k8s-ci-robot k8s-ci-robot added area/cloudprovider area/kube-proxy sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Aug 15, 2023
@rexagod
Copy link
Member Author

rexagod commented Aug 15, 2023

/hold
Until #119949 (comment) is done.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Aug 15, 2023
@bart0sh bart0sh moved this from Triage to Waiting on Author in SIG Node PR Triage Aug 15, 2023
@dashpole
Copy link
Contributor

/triage accepted
/assign @logicalhan

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 24, 2023
@dashpole
Copy link
Contributor

/assign @dgrisonnet

@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, cheftako and a team April 10, 2024 02:05
@richabanker richabanker mentioned this pull request Apr 14, 2024
Open
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2024
@k8s-ci-robot k8s-ci-robot added area/apiserver area/code-generation area/kubectl area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 5, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 5, 2024 •
edited

@rexagod: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-dependency-stats 087bf38 link false /test check-dependency-stats
pull-kubernetes-kind-dra 087bf38 link false /test pull-kubernetes-kind-dra
pull-kubernetes-node-e2e-crio-cgrpv1-dra 087bf38 link false /test pull-kubernetes-node-e2e-crio-cgrpv1-dra
pull-kubernetes-node-e2e-crio-cgrpv2-dra 087bf38 link false /test pull-kubernetes-node-e2e-crio-cgrpv2-dra
pull-kubernetes-node-e2e-containerd-1-7-dra 087bf38 link false /test pull-kubernetes-node-e2e-containerd-1-7-dra
pull-kubernetes-e2e-kind-kms f5856c9 link false /test pull-kubernetes-e2e-kind-kms

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rexagod
metrics: add exemplar support for counters
aa6138a 
adds exemplar support for counters
* utilizes Prometheus' underlying exemplar machinery
* introduces contextual counters (which were a no-op till now)
* adds testcases

addresses (a part of): kubernetes#119697
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logicalhan, rexagod
Once this PR has been reviewed and has the lgtm label, please assign johnbelamaric for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rexagod rexagod requested a review from dashpole June 5, 2024 20:58
dashpole
dashpole reviewed Jun 6, 2024
View reviewed changes
staging/src/k8s.io/component-base/metrics/metric.go
"span_id": maybeSpanCtx.SpanID().String(),
}
}
if m, ok := e.CounterMetric.(prometheus.ExemplarAdder); ok {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the CounterMetric always going to be an ExemplarAdder? Otherwise, it would be good to skip the creation of the exemplarLabels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole left review comments

@fatsheep9146 fatsheep9146 fatsheep9146 left review comments

@pohly pohly Awaiting requested review from pohly

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@YoyinZyc YoyinZyc Awaiting requested review from YoyinZyc

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@logicalhan logicalhan Awaiting requested review from logicalhan

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@logicalhan logicalhan

@dgrisonnet dgrisonnet

Labels
area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Status: Needs Triage
SIG CLI
Status: Needs Triage
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@rexagod @k8s-ci-robot @dashpole @dgrisonnet @dims @k8s-triage-robot @richabanker @logicalhan @fatsheep9146