Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v1.28.0 API testdata #119957

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Add v1.28.0 API testdata #119957

merged 1 commit into from
Aug 19, 2023

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Aug 16, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add v1.28.0 API testdata
https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/api/testdata#populating-data-for-each-release

Which issue(s) this PR fixes:

xref #119958

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 16, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 16, 2023
@SataQiu
Copy link
Member Author

SataQiu commented Aug 16, 2023

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 16, 2023
@SataQiu SataQiu mentioned this pull request Aug 16, 2023
Merged
SataQiu
SataQiu commented Aug 16, 2023
View reviewed changes
test/integration/etcd/etcd_storage_path_test.go Outdated
@@ -189,7 +189,7 @@ func TestEtcdStoragePath(t *testing.T) {
previousNonAlphaVersions.Insert(version)
}
}
if len(previousNonAlphaVersions) > 0 && !previousNonAlphaVersions.Has(expectedGVK.Version) {
if len(previousNonAlphaVersions) > 0 && !strings.Contains(expectedGVK.Version, "alpha") && !previousNonAlphaVersions.Has(expectedGVK.Version) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes:

TestEtcdStoragePath/admissionregistration.k8s.io/v1beta1,_Resource=validatingadmissionpolicies
    etcd_storage_path_test.go:193: Previous releases understand non-alpha versions ["v1beta1"], but do not understand the expected current storage version "v1alpha1". This means a current server will store data in etcd that is not understood by a previous version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpbetz @cici37 – I think we should have updated the storage version to beta in 1.28... persisting alpha data to etcd while the feature is beta means we probably can't just drop the alpha types

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened #120018 to switch the storage version and improve the etcd test to catch this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an oversight. Thanks for opening the PR to fix.

@SataQiu
Copy link
Member Author

SataQiu commented Aug 17, 2023

/retest

@SataQiu
Copy link
Member Author

SataQiu commented Aug 17, 2023

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Aug 17, 2023

verified the content of the v1.28.0 folder matches the content of the HEAD folder at the v1.28.0 tag

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8928c7e5e42a510979ae5977d66aca064e4d6d9e

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023
@liggitt
Copy link
Member

liggitt commented Aug 17, 2023

/hold

looking at the etcd test change

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
@SataQiu
Copy link
Member Author

SataQiu commented Aug 18, 2023

rebased #120018
Please take a look @liggitt

@liggitt
Copy link
Member

liggitt commented Aug 18, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 258bb5710499205248dfdc22f8147e3fc3ce43e6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SataQiu
Copy link
Member Author

SataQiu commented Aug 18, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2023
@SataQiu
Copy link
Member Author

SataQiu commented Aug 19, 2023

/test pull-kubernetes-integration

@dims
Copy link
Member

dims commented Aug 19, 2023

/assign @liggitt

@k8s-ci-robot k8s-ci-robot merged commit eae63c8 into kubernetes:master Aug 19, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@pwittrock pwittrock Awaiting requested review from pwittrock

@soltysh soltysh Awaiting requested review from soltysh

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SataQiu @k8s-ci-robot @liggitt @dims @jpbetz