-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing attempt to deploy past allocatable memory limits test on Windows #120948
Fixing attempt to deploy past allocatable memory limits test on Windows #120948
Conversation
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @jsturtevant |
/lgtm |
LGTM label has been added. Git tree hash: 2096cec94a4a58c2255fe914cbcdcf5484384ba8
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsturtevant, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug |
…0948-upstream-release-1.27 Automated cherry pick of #120948: Fixing attempt to deploy past allocatable memory limits test
…0948-upstream-release-1.26 Automated cherry pick of #120948: Fixing attempt to deploy past allocatable memory limits test
…0948-upstream-release-1.28 Automated cherry pick of #120948: Fixing attempt to deploy past allocatable memory limits test
What type of PR is this?
/kind failing-test
/area test
What this PR does / why we need it:
Fixes for
Kubernetes e2e suite: [It] [sig-windows] [Feature:Windows] Memory Limits [Serial] [Slow] attempt to deploy past allocatable memory limits should fail deployments of pods once there isn't enough memory
which is failing in several serial-slow jobs for Windows test passes.
Before these changes the pods that get scheduled to the cluster which are supposed to consume of off the 'allocatable' memory are failing to schedule due to the following message so this changes add a little buffer to ensure the pods are able to schedule and also adds additional logging
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig windows