Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an e2e test specific to kubeup clusters - Part Two #120977

Merged
merged 1 commit into from Oct 6, 2023

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Oct 3, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

addon-manager has been deprecated for a long time and we should stop testing it. This is not available in kops.

Should fix this failing test https://testgrid.k8s.io/sig-cluster-lifecycle-kubeup-to-kops#ci-kubernetes-e2e-cos-gce-slow-canary&include-filter-by-regex=Addon.update

The docs at kubernetes.io no longer mention addon-manager or how to install it.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

kubernetes/enhancements#4224

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 3, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 3, 2023
@upodroid
Copy link
Member Author

upodroid commented Oct 3, 2023

/cc @aojea @hakman @dims

@k8s-ci-robot k8s-ci-robot added area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 3, 2023
@hakman
Copy link
Member

hakman commented Oct 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 68014b7898c67b900121992ab7804ed8a3d3fd96

@hakman
Copy link
Member

hakman commented Oct 3, 2023

/assign @justinsb

@aojea
Copy link
Member

aojea commented Oct 3, 2023

/assign @BenTheElder

he has more historical context here

@upodroid
Copy link
Member Author

upodroid commented Oct 3, 2023

/retest

@justinsb
Copy link
Member

justinsb commented Oct 6, 2023

I suppose the challenge is that for the other kube-up tests, they still use the addon manager (kube-up is the only thing AFAIK). So if we broke the addon manager, we would know because the remaining kube-up tests would break. If this was the last kube-up test, 100% agreed. But we aren't really gaining anything from this test, other than maybe a bit more clarity if someone breaks the addon manager in the way this test verifies, so ....

/lgtm

@aojea
Copy link
Member

aojea commented Oct 6, 2023

/approve

the nice thing with git is that we can always revert it XD

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5714416 into kubernetes:master Oct 6, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants