New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove an e2e test specific to kubeup clusters - Part Two #120977
Remove an e2e test specific to kubeup clusters - Part Two #120977
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: 68014b7898c67b900121992ab7804ed8a3d3fd96
|
/assign @justinsb |
/assign @BenTheElder he has more historical context here |
/retest |
I suppose the challenge is that for the other kube-up tests, they still use the addon manager (kube-up is the only thing AFAIK). So if we broke the addon manager, we would know because the remaining kube-up tests would break. If this was the last kube-up test, 100% agreed. But we aren't really gaining anything from this test, other than maybe a bit more clarity if someone breaks the addon manager in the way this test verifies, so .... /lgtm |
/approve the nice thing with git is that we can always revert it XD |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
addon-manager has been deprecated for a long time and we should stop testing it. This is not available in kops.
Should fix this failing test https://testgrid.k8s.io/sig-cluster-lifecycle-kubeup-to-kops#ci-kubernetes-e2e-cos-gce-slow-canary&include-filter-by-regex=Addon.update
The docs at kubernetes.io no longer mention addon-manager or how to install it.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
kubernetes/enhancements#4224