ValidatingAdmissionPolicy: typed variables support. #121001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/apiserver
area/test
sig/api-machinery
jiahuif
force-pushed
the
feature/validating-admission-policy/typed-composition-variables
branch
from
3a4ace7
to
8b80ca6
Compare
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
jiahuif
force-pushed
the
feature/validating-admission-policy/typed-composition-variables
branch
from
8b80ca6
to
49cfb3d
Compare
|
/test pull-kubernetes-e2e-kind-alpha-features |
|
/lgtm /assign @jpbetz |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 129b1eb867fe8f68be59182ee8cd87017996bac3
|
jpbetz
reviewed
Oct 9, 2023
| @@ -196,3 +197,39 @@ func (a *variableAccessor) Callback(_ *lazy.MapValue) ref.Val { | |||
| } | |||
| return v | |||
| } | |||
|
|
|||
| func convertCelTypeToDeclType(celType *cel.Type) *apiservercel.DeclType { | |||
There was a problem hiding this comment.
Is it possible to capture type params?
There was a problem hiding this comment.
Yes it is! Added support for type params.
However, note that the object is still Dyn so any access to its field remains Dyn.
jiahuif
force-pushed
the
feature/validating-admission-policy/typed-composition-variables
branch
from
49cfb3d
to
826b44b
Compare
k8s-ci-robot
removed
the
lgtm
jiahuif
force-pushed
the
feature/validating-admission-policy/typed-composition-variables
branch
from
826b44b
to
c03579b
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: fb4efbe54eb715c28baeac3ce410efd4412caf5d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cici37, jiahuif, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
jiahuif
deleted the
feature/validating-admission-policy/typed-composition-variables
branch
|
@jiahuif Would you open the cherry pick for this one as well? Thank you! |
This was referenced Nov 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds tracking of the type of each compiled composition variable for further compilation in following variables and validation expressions.
Which issue(s) this PR fixes:
Fixes #120239
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: