Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proto file for gRPC pod-status service #121026

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add proto file for gRPC pod-status service #121026

wants to merge 1 commit into from

Conversation

kl52752
Copy link
Contributor

@kl52752 kl52752 commented Oct 6, 2023

Change-Id: I68cf94fccc7a032716368a7bacf4e82625e5245a

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

This PR adds gRPC server implementation for podstatus kubelet API for [KEP] (kubernetes/enhancements#4184)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 6, 2023
@kl52752
Copy link
Contributor Author

kl52752 commented Oct 6, 2023

/cc @robscott
/assign @SergeyKanzhelev

@aojea
Copy link
Member

aojea commented Oct 6, 2023

One tip, check the failing jobs and clock on the errors, in this case you can see in one of them

go version go1.21.1 linux/amd64
Your vendored results are different:
diff -Naupr -x 'AUTHORS*' -x 'CONTRIBUTORS*' vendor/k8s.io/kubelet/go.mod /home/prow/go/src/k8s.io/kubernetes/_tmp/kube-vendor.f2Gdn3/kubernetes/vendor/k8s.io/kubelet/go.mod
--- vendor/k8s.io/kubelet/go.mod	2023-10-06 13:43:01.607907458 +0000
+++ /home/prow/go/src/k8s.io/kubernetes/_tmp/kube-vendor.f2Gdn3/kubernetes/vendor/k8s.io/kubelet/go.mod	2023-10-06 13:46:50.894697461 +0000
@@ -9,6 +9,7 @@ require (
 	github.com/gogo/protobuf v1.3.2
 	github.com/stretchr/testify v1.8.2
 	google.golang.org/grpc v1.54.0
+	google.golang.org/protobuf v1.31.0
 	k8s.io/api v0.0.0
 	k8s.io/apimachinery v0.0.0
 	k8s.io/apiserver v0.0.0
@@ -50,7 +51,6 @@ require (
 	golang.org/x/time v0.3.0 // indirect
 	google.golang.org/appengine v1.6.7 // indirect
 	google.golang.org/genproto/googleapis/rpc v0.0.0-20230525234030-28d5490b6b19 // indirect
-	google.golang.org/protobuf v1.31.0 // indirect
 	gopkg.in/inf.v0 v0.9.1 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
Vendor Verify failed.
If you're seeing this locally, run the below command to fix your directories:
hack/update-vendor.sh
go version go1.21.1 linux/amd64
All pinned versions of checked dependencies match their preferred version.

so run hack/update-vendor.sh to update the dependencies correctly

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kl52752
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kl52752 kl52752 marked this pull request as draft October 9, 2023 07:24
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
@kl52752
Copy link
Contributor Author

kl52752 commented Oct 9, 2023

/retest

@kl52752
Add proto file for gRPC pod-status service
1ea85de 
Change-Id: I68cf94fccc7a032716368a7bacf4e82625e5245a
@kl52752 kl52752 marked this pull request as ready for review October 9, 2023 13:56
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2023
@dims
Copy link
Member

dims commented Oct 25, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 25, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 25, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Oct 25, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Oct 27, 2023

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 27, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Oct 27, 2023
@pacoxu pacoxu mentioned this pull request Nov 8, 2023
Open
6 tasks
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@aojea
Copy link
Member

aojea commented Apr 8, 2024

It needs also the implementation bits and tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbypage bobbypage Awaiting requested review from bobbypage

@sttts sttts Awaiting requested review from sttts

@robscott robscott Awaiting requested review from robscott

@hwdef hwdef Awaiting requested review from hwdef

@wzshiming wzshiming Awaiting requested review from wzshiming

Assignees

@SergeyKanzhelev SergeyKanzhelev

Labels
area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Status: Needs Reviewer
SIG Node PR Triage
Needs Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kl52752 @aojea @k8s-ci-robot @dims @bart0sh @k8s-triage-robot @SergeyKanzhelev