-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KEP-3085]: check PodReadyToStartContainers condition after gracefulshutdown #121044
[KEP-3085]: check PodReadyToStartContainers condition after gracefulshutdown #121044
Conversation
Skipping CI for Draft Pull Request. |
/test all |
8a16cbe
to
c62a02e
Compare
/test all |
c62a02e
to
47e28c0
Compare
/test all |
/retest-required pull-kubernetes-node-e2e-containerd was failed due to oom kill test |
/assign @kannon92 |
/test pull-kubernetes-node-e2e-containerd |
3c8c7a7
to
b8ba1cf
Compare
…n are set to false after terminating
b8ba1cf
to
ccc6458
Compare
https://storage.googleapis.com/k8s-triage/index.html?sig=node&test=GracefulNodeShutdown This can be used to find the test that is running this. You haven't triggered this test yet. /test |
@kannon92: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-kubernetes-node-kubelet-serial-containerd |
/retitle [KEP-3085]: check PodReadyToStartContainers condition after gracefulshutdown |
@charles-chenzz: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I asked @rphillips for his thoughts on this PR. Gracefulshutdown has been having some failures in tests lately so I don't think these failures are related to your code. |
/triage accepted |
LGTM label has been added. Git tree hash: d0dbf0a3757cd5451edba3f7846103e863a6d189
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charles-chenzz, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
this PR check status of pod ready to start condition are set to false after terminating.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
the test case should be add to promote kep 3085 to beta
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: