Add volume plugin label to SELinux metrics #121069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
jsafrane
changed the title
k8s-ci-robot
added
do-not-merge/needs-sig
Record volume plugin name when a volume in a Pod needs a different "mount -o context" value than the actually mounted one. We expect that NFS, CIFS and CephFS volumes would be able to mount such volumes just fine with multiple "-o context" values. We know that the block-volume based ones (ext4, xfs, btrfs, ...) cannot do that. Therefore want to distinguish the volume plugin in metrics, anything block-volume based could break an existing application.
jsafrane
force-pushed
the
ocp-add-plugin-label
branch
from
c78d540
to
0be5fdb
Compare
k8s-ci-robot
added
area/kubelet
sig/node
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/sig storage |
k8s-ci-robot
added
the
sig/storage
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/assign @xing-yang @msau42 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9f6d1534e475bab8bbf5e31d3d4e1174fb0a99d8
|
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Record volume plugin name when a volume in a Pod needs a different
"mount -o context"value than the actually mounted one.We expect that NFS, CIFS and CephFS volumes would be able to mount such volumes just fine with multiple
"-o context"values.We know that the block-volume based ones (ext4, xfs, btrfs, ...) cannot do that.
Therefore I want to distinguish the volume plugin in metrics, anything block-volume based could break an existing application.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: