Graduate ReadWriteOncePod to GA

[chrishenzie]

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change?

Graduate the `ReadWriteOncePod` feature gate to GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2485

/sig storage
/sig scheduling
/milestone 1.29
/cc @msau42
/cc @alculquicondor

[k8s-ci-robot]

@chrishenzie: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change?

Graduate the `ReadWriteOncePod` feature gate to GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2485

/sig storage
/sig scheduling
/milestone 1.29
/cc @msau42
/cc @alculquicondor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kerthcet]

Hi @chrishenzie from sig-scheduling, I think we have more places to remove this configuration, e.g.

• pkg/scheduler/framework/plugins
• pkg/scheduler/framework/plugins/feature
• pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions_test.go
• pkg/scheduler/framework/plugins/volumerestrictions/volume_restrictions.go

agree?

[chrishenzie]

@kerthcet From my understanding the plan is to remove all feature gating logic two releases after GA.

[chrishenzie]

/assign kerthcet

[alculquicondor]

Were the E2E tests completed during beta?
Can you add the links in the KEP? https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2485-read-write-once-pod-pv-access-mode#e2e-tests

[kerthcet]

@kerthcet From my understanding the plan is to remove all feature gating logic two releases after GA.

oh, I didn't know that, I thought since feature-gate GAed, we should remove all the related logics for we can't disable the feature anymore, like

func NewInTreeRegistry() runtime.Registry {
	fts := plfeature.Features{
		EnableReadWriteOncePod: feature.DefaultFeatureGate.Enabled(features.ReadWriteOncePod),
}

[chrishenzie]

Were the E2E tests completed during beta? Can you add the links in the KEP?

Yes they were. Updating in kubernetes/enhancements#4306.

[alculquicondor]

Please fix linter

[bart0sh]

/remove-sig node

[kerthcet]

/retest

[kerthcet]

LGTM fro sig-scheduling, so
/approve

[alculquicondor]

/lgtm
/approve
as well :)

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 72e79f69612b4262844068cb8d62a5f194f7ab21

[dims]

/assign @msau42 @xing-yang

(for sig-storage approval)

[msau42]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, chrishenzie, kerthcet, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [msau42]
• pkg/features/OWNERS [msau42]
• pkg/kubelet/volumemanager/OWNERS [msau42]
• pkg/scheduler/OWNERS [alculquicondor,kerthcet]
• pkg/volume/OWNERS [msau42]
• test/integration/scheduler/OWNERS [alculquicondor,kerthcet,msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@chrishenzie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-unit	2dbd405	link	unknown	/test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[pacoxu]

/test pull-kubernetes-unit
The flake is tracked in #121451